linux-kernel - Re: [PATCH v3 10/13] riscv: alternative: patch alternatives in the vDSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202301120754.lR520y7a-lkp@intel.com>
Date:   Thu, 12 Jan 2023 07:55:53 +0800
From:   kernel test robot <lkp@...el.com>
To:     Jisheng Zhang <jszhang@...nel.org>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        Anup Patel <anup@...infault.org>,
        Atish Patra <atishp@...shpatra.org>,
        Heiko Stuebner <heiko@...ech.de>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-riscv@...ts.infradead.org,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        kvm-riscv@...ts.infradead.org, Guo Ren <guoren@...nel.org>,
        Andrew Jones <ajones@...tanamicro.com>
Subject: Re: [PATCH v3 10/13] riscv: alternative: patch alternatives in the
 vDSO

Hi Jisheng,

I love your patch! Yet something to improve:

[auto build test ERROR on next-20230111]
[cannot apply to linus/master v6.2-rc3 v6.2-rc2 v6.2-rc1 v6.2-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jisheng-Zhang/riscv-fix-jal-offsets-in-patched-alternatives/20230112-012447
patch link:    https://lore.kernel.org/r/20230111171027.2392-11-jszhang%40kernel.org
patch subject: [PATCH v3 10/13] riscv: alternative: patch alternatives in the vDSO
config: riscv-randconfig-r042-20230110
compiler: riscv64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/42cd9e915a1622a4d9332fbecb5d85c1dffbbce7
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Jisheng-Zhang/riscv-fix-jal-offsets-in-patched-alternatives/20230112-012447
        git checkout 42cd9e915a1622a4d9332fbecb5d85c1dffbbce7
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   arch/riscv/kernel/alternative.c: In function 'apply_vdso_alternatives':
>> arch/riscv/kernel/alternative.c:172:35: error: 'vdso_start' undeclared (first use in this function); did you mean 'vfs_stat'?
     172 |         hdr = (struct elf64_hdr *)vdso_start;
         |                                   ^~~~~~~~~~
         |                                   vfs_stat
   arch/riscv/kernel/alternative.c:172:35: note: each undeclared identifier is reported only once for each function it appears in


vim +172 arch/riscv/kernel/alternative.c

   164	
   165	static void __init apply_vdso_alternatives(void)
   166	{
   167		const struct elf64_hdr *hdr;
   168		const struct elf64_shdr *shdr;
   169		const struct elf64_shdr *alt;
   170		struct alt_entry *begin, *end;
   171	
 > 172		hdr = (struct elf64_hdr *)vdso_start;
   173		shdr = (void *)hdr + hdr->e_shoff;
   174		alt = find_section(hdr, shdr, ".alternative");
   175		if (!alt)
   176			return;
   177	
   178		begin = (void *)hdr + alt->sh_offset,
   179		end = (void *)hdr + alt->sh_offset + alt->sh_size,
   180	
   181		_apply_alternatives((struct alt_entry *)begin,
   182				    (struct alt_entry *)end,
   183				    RISCV_ALTERNATIVES_BOOT);
   184	}
   185	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

View attachment "config" of type "text/plain" (171043 bytes)