linux-kernel - Re: [PATCH V9 4/5] ASoC: codecs: Aw883xx chip register file, data type file and Kconfig Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <5EA7B038-9B49-4E5D-8209-8689C0D03071@cutebit.org>
Date:   Wed, 11 Jan 2023 09:38:47 +0100
From:   Martin Povišer <povik+lin@...ebit.org>
To:     wangweidong.a@...nic.com
Cc:     lkp@...el.com, 13691752556@....com,
        Linux-ALSA <alsa-devel@...a-project.org>,
        Mark Brown <broonie@...nel.org>, cezary.rojewski@...el.com,
        ckeepax@...nsource.cirrus.com, daniel.beer@...rinstitute.com,
        devicetree@...r.kernel.org, flatmax@...tmax.com,
        james.schulman@...rus.com, jonathan.albrieux@...il.com,
        krzysztof.kozlowski+dt@...aro.org, lgirdwood@...il.com,
        linux-kernel@...r.kernel.org, liweilei@...nic.com,
        llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        perex@...ex.cz, pierre-louis.bossart@...ux.intel.com,
        rf@...nsource.cirrus.com, robh+dt@...nel.org,
        srinivas.kandagatla@...aro.org, steve@....org, tiwai@...e.com,
        yangxiaohua@...rest-semi.com, yijiangtao@...nic.com,
        zhaolei@...nic.com
Subject: Re: [PATCH V9 4/5] ASoC: codecs: Aw883xx chip register file, data
 type file and Kconfig Makefile


> On 11. 1. 2023, at 3:02, wangweidong.a@...nic.com wrote:
> 
> On 09/01/2023 03:00, kernel test robot wrote:

>> All errors (new ones prefixed by >>):
> 
>>>> ld.lld: error: undefined symbol: crc8_populate_lsb
>>>>> referenced by aw883xx_bin_parse.c:1049 (sound/soc/codecs/aw883xx/aw883xx_bin_parse.c:1049)
>>>>>              vmlinux.o:(aw883xx_dev_load_acf_check)
>> --
>>>> ld.lld: error: undefined symbol: crc8
>>>>> referenced by aw883xx_bin_parse.c:963 (sound/soc/codecs/aw883xx/aw883xx_bin_parse.c:963)
>>>>>              vmlinux.o:(aw883xx_dev_load_acf_check)
>>>>> referenced by aw883xx_bin_parse.c:1022 (sound/soc/codecs/aw883xx/aw883xx_bin_parse.c:1022)
>>>>>              vmlinux.o:(aw883xx_dev_load_acf_check)
>>>>> did you mean: crc4
>>>>> defined in: vmlinux.o
> 
> This looks like a false positive. crc8_populate_lsb is defined in the lib/crc8.c file.
> I also could not reproduce it with GCC.

Hi,

the issue here would be that it’s possible to select your driver for compilation without
having selected the CRC8 functions, leading to the linkage error.

You can fix that by adding ’select CRC8’ under the Kconfig section of your driver, similarly
to how the SND_SOC_SIGMADSP symbol selects CRC32.

Best regards,
Martin

> 
> Best regards,
> Weidong Wang