linux-kernel - Re: [PATCH V9 4/5] ASoC: codecs: Aw883xx chip register file, data type file and Kconfig Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1301a59a-9085-c7f5-bc1c-ce09766806a1@linaro.org>
Date:   Wed, 11 Jan 2023 09:53:47 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     wangweidong.a@...nic.com, lkp@...el.com
Cc:     13691752556@....com, alsa-devel@...a-project.org,
        broonie@...nel.org, cezary.rojewski@...el.com,
        ckeepax@...nsource.cirrus.com, daniel.beer@...rinstitute.com,
        devicetree@...r.kernel.org, flatmax@...tmax.com,
        james.schulman@...rus.com, jonathan.albrieux@...il.com,
        krzysztof.kozlowski+dt@...aro.org, lgirdwood@...il.com,
        linux-kernel@...r.kernel.org, liweilei@...nic.com,
        llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        perex@...ex.cz, pierre-louis.bossart@...ux.intel.com,
        povik+lin@...ebit.org, rf@...nsource.cirrus.com,
        robh+dt@...nel.org, srinivas.kandagatla@...aro.org, steve@....org,
        tiwai@...e.com, yangxiaohua@...rest-semi.com,
        yijiangtao@...nic.com, zhaolei@...nic.com
Subject: Re: [PATCH V9 4/5] ASoC: codecs: Aw883xx chip register file, data
 type file and Kconfig Makefile

On 11/01/2023 03:02, wangweidong.a@...nic.com wrote:
> On 09/01/2023 03:00, kernel test robot wrote:
>> Hi,
> 
>> Thank you for the patch! Yet something to improve:
> 
>> [auto build test ERROR on 1f5abbd77e2c1787e74b7c2caffac97def78ba52]
> 
>> url:    https://github.com/intel-lab-lkp/linux/commits/wangweidong-a-awinic-com/ASoC-codecs-Add-i2c-and-codec-registration-for-aw883xx-and-their-associated-operation-functions/20230106-113130
>> base:   1f5abbd77e2c1787e74b7c2caffac97def78ba52
>> patch link:    https://lore.kernel.org/r/20230106032835.141918-5-wangweidong.a%40awinic.com
>> patch subject: [PATCH V9 4/5] ASoC: codecs: Aw883xx chip register file, data type file and Kconfig Makefile
>> config: arm64-randconfig-r034-20230109
>> compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 8d9828ef5aa9688500657d36cd2aefbe12bbd162)
>> reproduce (this is a W=1 build):
>>        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>        chmod +x ~/bin/make.cross
>>        # install arm64 cross compiling tool for clang build
>>        # apt-get install binutils-aarch64-linux-gnu
>>        # https://github.com/intel-lab-lkp/linux/commit/63bed80c0eacb29f78eb53987b34863bafd48cee
>>        git remote add linux-review https://github.com/intel-lab-lkp/linux
>>        git fetch --no-tags linux-review wangweidong-a-awinic-com/ASoC-codecs-Add-i2c-and-codec-registration-for-aw883xx-and-their-associated-operation-functions/20230106-113130
>>        git checkout 63bed80c0eacb29f78eb53987b34863bafd48cee
>>        # save the config file
>>        mkdir build_dir && cp config build_dir/.config
>>        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 olddefconfig
>>        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash
> 
>> If you fix the issue, kindly add following tag where applicable
>> | Reported-by: kernel test robot <lkp@...el.com>
> 
>> All errors (new ones prefixed by >>):
> 
>>>> ld.lld: error: undefined symbol: crc8_populate_lsb
>>   >>> referenced by aw883xx_bin_parse.c:1049 (sound/soc/codecs/aw883xx/aw883xx_bin_parse.c:1049)
>>   >>>               vmlinux.o:(aw883xx_dev_load_acf_check)
>> --
>>>> ld.lld: error: undefined symbol: crc8
>>   >>> referenced by aw883xx_bin_parse.c:963 (sound/soc/codecs/aw883xx/aw883xx_bin_parse.c:963)
>>   >>>               vmlinux.o:(aw883xx_dev_load_acf_check)
>>   >>> referenced by aw883xx_bin_parse.c:1022 (sound/soc/codecs/aw883xx/aw883xx_bin_parse.c:1022)
>>   >>>               vmlinux.o:(aw883xx_dev_load_acf_check)
>>   >>> did you mean: crc4
>>   >>> defined in: vmlinux.o
> 
> This looks like a false positive. crc8_populate_lsb is defined in the lib/crc8.c file.
> I also could not reproduce it with GCC.

kernel test robot almost does not report false positives, at least not
in such obvious cases. Chances you get here false positive are so small
(although possible), that it is much, much more likely your code needs
fixing.

Best regards,
Krzysztof