linux-kernel - Re: [PATCH v2] iio: temperature: Add MCP9600 thermocouple EMF converter driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230112190551.4d9ac5f6@jic23-huawei>
Date:   Thu, 12 Jan 2023 19:05:51 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Andrew Hepp <andrew.hepp@...pp.dev>
Cc:     linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] iio: temperature: Add MCP9600 thermocouple EMF
 converter driver

On Sun,  8 Jan 2023 15:45:04 -0800
Andrew Hepp <andrew.hepp@...pp.dev> wrote:

> From: "Andrew Hepp" <andrew.hepp@...pp.dev>
> 
> Add support for the MCP9600 thermocouple EMF converter.
> 
> Datasheet: https://ww1.microchip.com/downloads/en/DeviceDoc/MCP960X-Data-Sheet-20005426.pdf
> Signed-off-by: Andrew Hepp <andrew.hepp@...pp.dev>

Driver looks good, but now I realise we don't have a device tree binding doc.

Please add one for v3.

Note that the binding doc is describing the hardware, not what the driver
currently supports alone, so include the 4 (or 6?) interrupt lines (and interrupt-names
as any random subset of them might be provided) + VDD regulator + anything else I've
not noticed in my 10 second look at the datashet.

Thanks,

Jonathan