linux-kernel - Re: [PATCH 2/4] ARM: pxa: remove further dead code after pxa93 support removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKXUXMzRk1aK-_kELB7dZXAS711HuiF4TGaf_BgDK=dhY=iyVQ@mail.gmail.com>
Date:   Thu, 12 Jan 2023 10:26:00 +0100
From:   Lukas Bulwahn <lukas.bulwahn@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Aaro Koskinen <aaro.koskinen@....fi>,
        Janusz Krzysztofik <jmkrzyszt@...il.com>,
        Tony Lindgren <tony@...mide.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        linux-arm-kernel@...ts.infradead.org,
        Linux-OMAP <linux-omap@...r.kernel.org>,
        linux-usb@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] ARM: pxa: remove further dead code after pxa93
 support removal

On Thu, Jan 12, 2023 at 10:06 AM Arnd Bergmann <arnd@...db.de> wrote:
>
> On Thu, Jan 12, 2023, at 09:37, Lukas Bulwahn wrote:
> > Commit 150ccb6f9a89 ("ARM: pxa: remove pxa93x support") removes configs
> > CPU_PXA930 and CPU_PXA935 and uses of cpu_is_pxa93x() and cpu_is_pxa935().
> >
> > Remove some further dead code in ./include/linux/soc/pxa/cpu.h on top of
> > that commit above.
> >
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
>
> I had this in an earlier version and ended up leaving this bit in
> when I reworked the series to not drop support for PXA310 and PXA320.
>
> You are probably right that we should not reference the removed
> Kconfig symbols, but I see that this causes a regression
> unless I also bring back the change to
>
> drivers/mmc/host/pxamci.c:                              || cpu_is_pxa935())
>

Thanks for the insights of your previous attempt. In my janitorial
work, I am just triggered by references to removed configs and hardly
have the resources to test all the various arm pxa configs. Let us
keep it as is for now, and see once your clean-up has settled in
mainline, if we find a good suitable further cleanup patch on these
code parts here then.

Lukas