linux-kernel - Re: [PATCH -v2 0/9] migrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877cxrro10.fsf@yhuang6-desk2.ccr.corp.intel.com>
Date:   Fri, 13 Jan 2023 13:39:39 +0800
From:   "Huang, Ying" <ying.huang@...el.com>
To:     Mike Kravetz <mike.kravetz@...cle.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Zi Yan <ziy@...dia.com>,
        Yang Shi <shy828301@...il.com>,
        Baolin Wang <baolin.wang@...ux.alibaba.com>,
        Oscar Salvador <osalvador@...e.de>,
        Matthew Wilcox <willy@...radead.org>,
        Bharata B Rao <bharata@....com>,
        Alistair Popple <apopple@...dia.com>,
        haoxin <xhao@...ux.alibaba.com>
Subject: Re: [PATCH -v2 0/9] migrate_pages(): batch TLB flushing

Mike Kravetz <mike.kravetz@...cle.com> writes:

> On 01/13/23 10:42, Huang, Ying wrote:
>> Mike Kravetz <mike.kravetz@...cle.com> writes:
>> > On 01/12/23 15:17, Huang, Ying wrote:
>> >> Mike Kravetz <mike.kravetz@...cle.com> writes:
>> >> > On 01/12/23 08:09, Huang, Ying wrote:
>> >
>> > Isolated to patch,
>> > [PATCH -v2 4/9] migrate_pages: split unmap_and_move() to _unmap() and _move()
>> >
>> > Actually, recreated/isolated by just applying this series to v6.2-rc3 in an
>> > effort to eliminate any possible noise in linux-next.
>> >
>> > Spent a little time looking at modifications made there, but nothing stood out.
>> > Will investigate more as time allows.
>> 
>> Thank you very much!  That's really helpful.
>> 
>> Checked that patch again, found that there's an issue about non-lru
>> pages.  Do you enable zram in your test system?  Can you try the
>> below debug patch on top of
>
> CONFIG_ZRAM=y
>
>> 
>> [PATCH -v2 4/9] migrate_pages: split unmap_and_move() to _unmap() and _move()
>> 
>> The following patches in series need to be rebased for the below
>> change.  I will test with zram enabled too.
>
> A quick test with below patch on top of [PATCH -v2 4/9] (without the rest of
> the series applied) makes the issue go away.  Thanks!

Thanks you very much!  Now I can reproduce the issue with zram
configured.  Will send out a new version to fix the issue.

Best Regards,
Huang, Ying