linux-kernel - Re: [PATCH] memory: renesas-rpc-if: Fix PHYCNT.STRTIM setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y8E8IzJYqhTXLALE@ninjato>
Date:   Fri, 13 Jan 2023 12:10:27 +0100
From:   Wolfram Sang <wsa+renesas@...g-engineering.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     linux-renesas-soc@...r.kernel.org,
        Prabhakar <prabhakar.csengg@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] memory: renesas-rpc-if: Fix PHYCNT.STRTIM setting


> > +       regmap_update_bits(rpc->regmap, RPCIF_PHYCNT,
> > +                          RPCIF_PHYCNT_STRTIM(rpc->info->strtim),
> > +                          RPCIF_PHYCNT_STRTIM(rpc->info->strtim));
> 
> I'm not sure this is guaranteed to work, as using rpc->info->strtim as
> the mask may not clear all bits (e.g. on R-Car M3-W it is 6, not 7), and
> the initial values of the bits are documented to be undefined.

Okay, thanks! I will fix this.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)