linux-kernel - Re: [PATCH v5 1/2] usb: serial: add support for CH348

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <0fa6e2b8-0585-87a3-f255-5301774a6d9d@ixit.cz>
Date:   Sat, 14 Jan 2023 22:05:18 +0100
From:   David Heidelberg <david@...t.cz>
To:     clabbe@...libre.com
Cc:     gregkh@...uxfoundation.org, johan@...nel.org,
        LKML <linux-kernel@...r.kernel.org>, linux-usb@...r.kernel.org
Subject: Re: [PATCH v5 1/2] usb: serial: add support for CH348

Acked-by: David Heidelberg <david@...t.cz>

 > +    int i;
 > +
 > +    for (i = 1; i < CH348_MAXPORT; ++i) {

One nitpick; it would be nice to have a "for" loop from C99+.

-- 
David Heidelberg
Consultant Software Engineer