linux-kernel - Re: [PATCH v5 1/2] usb: serial: add support for CH348

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y8UFC/1vH/Y9PeBN@hovoldconsulting.com>
Date:   Mon, 16 Jan 2023 09:04:27 +0100
From:   Johan Hovold <johan@...nel.org>
To:     David Heidelberg <david@...t.cz>
Cc:     clabbe@...libre.com, gregkh@...uxfoundation.org,
        LKML <linux-kernel@...r.kernel.org>, linux-usb@...r.kernel.org
Subject: Re: [PATCH v5 1/2] usb: serial: add support for CH348

[ Please fix your mailer which generates broken Reply-To headers:

	Reply-To: 20230106135338.643951-2-clabbe@...libre.com
]

On Sat, Jan 14, 2023 at 10:05:18PM +0100, David Heidelberg wrote:
> Acked-by: David Heidelberg <david@...t.cz>
> 
>  > +    int i;
>  > +
>  > +    for (i = 1; i < CH348_MAXPORT; ++i) {
> 
> One nitpick; it would be nice to have a "for" loop from C99+.

No, I prefer this as it stands (and we only have about 80 instances of
such fancy stuff outside of tooling it seems).

Johan