linux-kernel - Re: [PATCH v2 2/2] gpio: wcd934x: Use proper headers and drop OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y8U8bZ9+dOwmDgsb@smile.fi.intel.com>
Date:   Mon, 16 Jan 2023 14:00:45 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v2 2/2] gpio: wcd934x: Use proper headers and drop
 OF_GPIO dependency

On Mon, Jan 16, 2023 at 10:03:47AM +0100, Bartosz Golaszewski wrote:
> On Fri, Jan 13, 2023 at 7:25 PM Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:

...

> > +#include <linux/mod_devicetable.h>
> >  #include <linux/module.h>
> > -#include <linux/gpio/driver.h>
> > +#include <linux/platform_device.h>
> >  #include <linux/regmap.h>
> >  #include <linux/slab.h>
> > -#include <linux/of_device.h>
> > +
> > +#include <linux/gpio/driver.h>
> 
> Any reason for having it separately here?

Yes. The idea is to emphasize the relationship between the driver and
the subsystem it's written for.

P.S. Thanks for applying the rest of my contribution.

-- 
With Best Regards,
Andy Shevchenko