linux-kernel - Re: [PATCH 2/2] gpio: vf610: Support building gpio-vf610 driver as module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZDbsNsaQ+9sM2BEiKXJhJuGU7jk2M07L5TRZ6H1u2VFg@mail.gmail.com>
Date:   Tue, 17 Jan 2023 15:12:56 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Bough Chen <haibo.chen@....com>
Cc:     "brgl@...ev.pl" <brgl@...ev.pl>,
        "stefan@...er.ch" <stefan@...er.ch>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] gpio: vf610: Support building gpio-vf610 driver as module

On Tue, Jan 17, 2023 at 3:01 PM Bough Chen <haibo.chen@....com> wrote:
> > On Tue, Dec 20, 2022 at 10:02 AM <haibo.chen@....com> wrote:
> >
> > > From: Haibo Chen <haibo.chen@....com>
> > >
> > > To support Android GKI, need to build this driver as module.
> > > So change the config as tristate type, and add module license.
> > >
> > > Signed-off-by: Jindong Yue <jindong.yue@....com>
> > > Signed-off-by: Haibo Chen <haibo.chen@....com>
> >
> > OK...
> >
> > >  builtin_platform_driver(vf610_gpio_driver);
> >
> > Then you want something like module_platform_driver() here.
>
> Hi Linus,
>
> Here, though need to build this gpio driver as module due to the Android GKI, but we do not really need to
> rmmod/unbind this driver, so do not need to implement the _exit or remove callback.
> In this case, still need to change to module_platform_driver()?
> If so, after use the module_platform_driver(), is it okay to not implement the __exit /remove callback?

Yes, our project is about maintaining and improving the Linux kernel, GKI
is not a project we are running. If they need stuff from Linux, it happens on
our terms, and that is that modularization should be self-motivated.

Check this article:
https://lwn.net/Articles/872209/

Yours,
Linus Walleij