linux-kernel - Re: [PATCH 0/6] ksmbd: Minor performance improvement & code cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKYAXd8AjjzXWEmMDydgRm1p6F7Fo-s836iWryRGeQPYbjcQTQ@mail.gmail.com>
Date:   Wed, 18 Jan 2023 00:07:25 +0900
From:   Namjae Jeon <linkinjeon@...nel.org>
To:     Dawei Li <set_pte_at@...look.com>
Cc:     sfrench@...ba.org, senozhatsky@...omium.org, tom@...pey.com,
        hyc.lee@...il.com, linux-cifs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/6] ksmbd: Minor performance improvement & code cleanup

2023-01-15 19:32 GMT+09:00, Dawei Li <set_pte_at@...look.com>:
> It's a small series mostly aimed at performance improvement and code
> cleanup.
>
> Among which, First three ones are performance related commits, and
> other ones are minor code cleanup.
except 0005 patch, Acked-by: Namjae Jeon <linkinjeon@...nel.org>

Thanks for your patch!
>
> 1 & 2: list => xarray, acclerating index based lookup.
> 3: rwlock => rcu primitive, enabling write & read concurrency.
> 4: Simple duplicated code removal.
> 5: Minor code rework and exception handling.
> 6: Simple typo fix.
>
> Dawei Li (6):
>   ksmbd: Implements sess->ksmbd_chann_list as xarray
>   ksmbd: Implements sess->rpc_handle_list as xarray
>   ksmbd: replace rwlock with rcu for concurrenct access on conn list
>   ksmbd: Remove duplicated codes
>   ksmbd: improve exception handling and avoid redundant sanity check in
>     loop
>   ksmbd: fix typo, syncronous->synchronous
>
>  fs/ksmbd/asn1.c              | 19 ++++---
>  fs/ksmbd/connection.c        | 54 +++++++++++---------
>  fs/ksmbd/connection.h        |  1 -
>  fs/ksmbd/ksmbd_work.h        |  2 +-
>  fs/ksmbd/mgmt/user_session.c | 98 ++++++++++++++----------------------
>  fs/ksmbd/mgmt/user_session.h |  6 +--
>  fs/ksmbd/smb2pdu.c           | 52 ++++++-------------
>  7 files changed, 93 insertions(+), 139 deletions(-)
>
> --
> 2.25.1
>
>