linux-kernel - Re: [PATCH v3 2/4] powercap: idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jzYbpeVxtuqMWUN+X-wwYtKYq=7Ky3jRnb_S6NZc1RVQ@mail.gmail.com>
Date:   Tue, 17 Jan 2023 16:09:48 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>
Cc:     Daniel Lezcano <daniel.lezcano@...aro.org>, rafael@...nel.org,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        rui.zhang@...el.com, amitk@...nel.org
Subject: Re: [PATCH v3 2/4] powercap: idle_inject: Add update callback

On Tue, Jan 17, 2023 at 4:08 PM srinivas pandruvada
<srinivas.pandruvada@...ux.intel.com> wrote:
>
> On Tue, 2023-01-17 at 12:13 +0100, Daniel Lezcano wrote:
> > On 17/01/2023 03:07, Srinivas Pandruvada wrote:
> >
> > [ ... ]
> >
> > > +struct idle_inject_device *idle_inject_register(struct cpumask
> > > *cpumask)
> > > +{
> > > +       return idle_inject_register_full(cpumask, NULL);
> > > +}
> > >   EXPORT_SYMBOL_NS_GPL(idle_inject_register, IDLE_INJECT);
> >
> > Why not just add the parameter to idle_inject_register() ?
> >
> > There is only one user ATM
> That was done in v1. But Rafael suggested to avoid changes to existing
> kernel source.

However, it can be done if Daniel prefers that.  It is 1 callback now
only, so no big deal I suppose.