linux-kernel - Re: [PATCH] scsi: qla2xxx: Change qla_trim_buf,__qla_adjust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1wn5jo16v.fsf@ca-mkp.ca.oracle.com>
Date:   Wed, 18 Jan 2023 18:47:13 -0500
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Tom Rix <trix@...hat.com>
Cc:     njavali@...vell.com, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, qutran@...vell.com,
        GR-QLogic-Storage-Upstream@...vell.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: qla2xxx: Change qla_trim_buf,__qla_adjust_buf
 functions to static


Tom,

> Smatch reports
> drivers/scsi/qla2xxx/qla_mid.c:1189:6: warning: symbol 'qla_trim_buf' was not declared. Should it be static?
> drivers/scsi/qla2xxx/qla_mid.c:1221:6: warning: symbol '__qla_adjust_buf' was not declared. Should it be static?
>
> These functions are only used in qla_mid.c, so they should be static.

Applied to 6.3/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering