linux-kernel - Re: [PATCH] rpmsg: glink: Include types in qcom_glink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <71789b4c-016d-835d-8b1e-3b962918eefc@quicinc.com>
Date:   Tue, 17 Jan 2023 16:41:23 -0800
From:   Chris Lew <quic_clew@...cinc.com>
To:     Bjorn Andersson <quic_bjorande@...cinc.com>,
        Bjorn Andersson <andersson@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>
CC:     <linux-arm-msm@...r.kernel.org>,
        <linux-remoteproc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rpmsg: glink: Include types in qcom_glink_native.h



On 1/9/2023 2:37 PM, Bjorn Andersson wrote:
> Ensure that the used data types are available in qcom_glink_native.h, to
> silence LSP warnings.
> 
> Signed-off-by: Bjorn Andersson <quic_bjorande@...cinc.com>

Reviewed-by: Chris Lew <quic_clew@...cinc.com>

> ---
>   drivers/rpmsg/qcom_glink_native.h | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/rpmsg/qcom_glink_native.h b/drivers/rpmsg/qcom_glink_native.h
> index 624184fc458e..e9a8671616c7 100644
> --- a/drivers/rpmsg/qcom_glink_native.h
> +++ b/drivers/rpmsg/qcom_glink_native.h
> @@ -6,6 +6,8 @@
>   #ifndef __QCOM_GLINK_NATIVE_H__
>   #define __QCOM_GLINK_NATIVE_H__
>   
> +#include <linux/types.h>
> +
>   #define GLINK_FEATURE_INTENT_REUSE	BIT(0)
>   #define GLINK_FEATURE_MIGRATION		BIT(1)
>   #define GLINK_FEATURE_TRACER_PKT	BIT(2)
> @@ -24,6 +26,7 @@ struct qcom_glink_pipe {
>   		      const void *data, size_t dlen);
>   };
>   
> +struct device;
>   struct qcom_glink;
>   
>   struct qcom_glink *qcom_glink_native_probe(struct device *dev,
>