linux-kernel - fs/ksmbd/unicode.c:122:19: warning: unused function 'is_char

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 18 Jan 2023 21:06:37 +0800
From:   kernel test robot <lkp@...el.com>
To:     Namjae Jeon <namjae.jeon@...sung.com>
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        linux-kernel@...r.kernel.org, Christoph Hellwig <hch@....de>,
        Steve French <stfrench@...rosoft.com>
Subject: fs/ksmbd/unicode.c:122:19: warning: unused function 'is_char_allowed'

Hi Namjae,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   c1649ec55708ae42091a2f1bca1ab49ecd722d55
commit: 1a93084b9a89818aec0ac7b59a5a51f2112bf203 ksmbd: move fs/cifsd to fs/ksmbd
date:   1 year, 7 months ago
config: hexagon-buildonly-randconfig-r001-20230118
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 4196ca3278f78c6e19246e54ab0ecb364e37d66a)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1a93084b9a89818aec0ac7b59a5a51f2112bf203
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 1a93084b9a89818aec0ac7b59a5a51f2112bf203
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash fs/ksmbd/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> fs/ksmbd/unicode.c:122:19: warning: unused function 'is_char_allowed' [-Wunused-function]
   static inline int is_char_allowed(char *ch)
                     ^
   1 warning generated.


vim +/is_char_allowed +122 fs/ksmbd/unicode.c

e2f34481b24db2 fs/cifsd/unicode.c Namjae Jeon 2021-03-16  115  
e2f34481b24db2 fs/cifsd/unicode.c Namjae Jeon 2021-03-16  116  /*
e2f34481b24db2 fs/cifsd/unicode.c Namjae Jeon 2021-03-16  117   * is_char_allowed() - check for valid character
e2f34481b24db2 fs/cifsd/unicode.c Namjae Jeon 2021-03-16  118   * @ch:		input character to be checked
e2f34481b24db2 fs/cifsd/unicode.c Namjae Jeon 2021-03-16  119   *
e2f34481b24db2 fs/cifsd/unicode.c Namjae Jeon 2021-03-16  120   * Return:	1 if char is allowed, otherwise 0
e2f34481b24db2 fs/cifsd/unicode.c Namjae Jeon 2021-03-16  121   */
e2f34481b24db2 fs/cifsd/unicode.c Namjae Jeon 2021-03-16 @122  static inline int is_char_allowed(char *ch)
e2f34481b24db2 fs/cifsd/unicode.c Namjae Jeon 2021-03-16  123  {
e2f34481b24db2 fs/cifsd/unicode.c Namjae Jeon 2021-03-16  124  	/* check for control chars, wildcards etc. */
e2f34481b24db2 fs/cifsd/unicode.c Namjae Jeon 2021-03-16  125  	if (!(*ch & 0x80) &&
e2f34481b24db2 fs/cifsd/unicode.c Namjae Jeon 2021-03-16  126  	    (*ch <= 0x1f ||
e2f34481b24db2 fs/cifsd/unicode.c Namjae Jeon 2021-03-16  127  	     *ch == '?' || *ch == '"' || *ch == '<' ||
e2f34481b24db2 fs/cifsd/unicode.c Namjae Jeon 2021-03-16  128  	     *ch == '>' || *ch == '|'))
e2f34481b24db2 fs/cifsd/unicode.c Namjae Jeon 2021-03-16  129  		return 0;
e2f34481b24db2 fs/cifsd/unicode.c Namjae Jeon 2021-03-16  130  
e2f34481b24db2 fs/cifsd/unicode.c Namjae Jeon 2021-03-16  131  	return 1;
e2f34481b24db2 fs/cifsd/unicode.c Namjae Jeon 2021-03-16  132  }
e2f34481b24db2 fs/cifsd/unicode.c Namjae Jeon 2021-03-16  133  

:::::: The code at line 122 was first introduced by commit
:::::: e2f34481b24db2fd634b5edb0a5bd0e4d38cc6e9 cifsd: add server-side procedures for SMB3

:::::: TO: Namjae Jeon <namjae.jeon@...sung.com>
:::::: CC: Steve French <stfrench@...rosoft.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

View attachment "config" of type "text/plain" (109701 bytes)