linux-kernel - Re: [PATCH v3 3/6] dt-bindings: mailbox: qcom: correct the list of platforms using clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 18 Jan 2023 14:08:28 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Taniya Das <quic_tdas@...cinc.com>,
        Jassi Brar <jassisinghbrar@...il.com>
Cc:     linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/6] dt-bindings: mailbox: qcom: correct the list of
 platforms using clocks

On 18/01/2023 14:04, Dmitry Baryshkov wrote:
> On 18/01/2023 13:41, Krzysztof Kozlowski wrote:
>> On 17/01/2023 23:30, Dmitry Baryshkov wrote:
>>> Only three platforms require `pll' and `aux' clocks: msm8916, msm8939
>>> and qcs404. Correct the list of platforms in the corresponding clause.
>>>
>>> Fixes: 0d17014e9189 ("dt-bindings: mailbox: Add binding for SDX55 APCS")
>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
>>> ---
>>>   .../mailbox/qcom,apcs-kpss-global.yaml        | 33 ++++++++++++++-----
>>>   1 file changed, 25 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
>>> index ecc286ab49ef..7d8de7a16984 100644
>>> --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
>>> +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
>>> @@ -72,15 +72,8 @@ allOf:
>>>           compatible:
>>>             enum:
>>>               - qcom,msm8916-apcs-kpss-global
>>> -            - qcom,msm8994-apcs-kpss-global
>>> -            - qcom,msm8996-apcs-hmss-global
>>> -            - qcom,msm8998-apcs-hmss-global
>>> +            - qcom,msm8939-apcs-kpss-global
>>>               - qcom,qcs404-apcs-apps-global
>>> -            - qcom,sc7180-apss-shared
>>> -            - qcom,sdm660-apcs-hmss-global
>>> -            - qcom,sdm845-apss-shared
>>> -            - qcom,sm6125-apcs-hmss-global
>>> -            - qcom,sm8150-apss-shared
>>>       then:
>>>         properties:
>>>           clocks:
>>> @@ -124,6 +117,30 @@ allOf:
>>>             items:
>>>               - const: pll
>>>               - const: xo
>>> +
>>> +  - if:
>>> +      properties:
>>> +        compatible:
>>> +          enum:
>>> +            - qcom,msm8953-apcs-kpss-global
>>> +            - qcom,msm8976-apcs-kpss-global
>>> +            - qcom,msm8994-apcs-kpss-global
>>> +            - qcom,msm8996-apcs-hmss-global
>>> +            - qcom,msm8998-apcs-hmss-global
>>> +            - qcom,qcm2290-apcs-hmss-global
>>> +            - qcom,sc7180-apss-shared
>>> +            - qcom,sc8180x-apss-shared
>>> +            - qcom,sdm660-apcs-hmss-global
>>> +            - qcom,sdm845-apss-shared
>>> +            - qcom,sm4250-apcs-hmss-global
>>> +            - qcom,sm6115-apcs-hmss-global
>>> +            - qcom,sm6125-apcs-hmss-global
>>> +            - qcom,sm8150-apss-shared
>>
>> Isn't this in multiple places now? This doesn't match what you remove
>> either.
> 
> Yes, I addsd several platforms. I can split this into two patches: one 
> moving the platforms and another one adding missing platforms. Would you 
> prefer it?

Yes, plus you now duplicated entries, didn't you? As I pointed - some of
them are in multiple places now.

Best regards,
Krzysztof