linux-kernel - Re: [PATCH 1/5] ASoC: samsung: remove DMA filter function and data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y8l21Kb42l2ZcIC+@sirena.org.uk>
Date:   Thu, 19 Jan 2023 16:59:00 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Arnd Bergmann <arnd@...db.de>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        alsa-devel@...a-project.org
Subject: Re: [PATCH 1/5] ASoC: samsung: remove DMA filter function and data

On Wed, Jan 18, 2023 at 05:10:45PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> This data is no longer passed by the platform code, so
> there is no point passing it down at all.

This breaks an x86 allmodconfig build:

/build/stage/linux/sound/soc/samsung/s3c24xx-i2s.c: In function ‘s3c24xx_iis_dev_probe’:
/build/stage/linux/sound/soc/samsung/s3c24xx-i2s.c:436:56: error: passing argument 4 of ‘samsung_asoc_dma_platform_register’ from incompatible pointer type [-Werror=incompatible-pointer-types]
  436 |                                                  "tx", "rx", NULL);
      |                                                        ^~~~
      |                                                        |
      |                                                        char *
In file included from /build/stage/linux/sound/soc/samsung/s3c24xx-i2s.c:21:
/build/stage/linux/sound/soc/samsung/dma.h:17:55: note: expected ‘struct device *’ but argument is of type ‘char *’
   17 |                                        struct device *dma_dev);
      |                                        ~~~~~~~~~~~~~~~^~~~~~~
/build/stage/linux/sound/soc/samsung/s3c24xx-i2s.c:435:15: error: too many arguments to function ‘samsung_asoc_dma_platform_register’
  435 |         ret = samsung_asoc_dma_platform_register(&pdev->dev, NULL,
      |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/build/stage/linux/sound/soc/samsung/dma.h:15:5: note: declared here
   15 | int samsung_asoc_dma_platform_register(struct device *dev,
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)