linux-kernel - Re: [PATCH v3 0/4] gpiolib: get rid of exessive ->of_gpio_ranges

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b16c0134-b8a6-573c-4ad9-c4620fc98d5c@i2se.com>
Date:   Thu, 19 Jan 2023 18:28:27 +0100
From:   Stefan Wahren <stefan.wahren@...e.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Florian Fainelli <f.fainelli@...il.com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>
Subject: Re: [PATCH v3 0/4] gpiolib: get rid of exessive
 ->of_gpio_ranges_fallback()

Hi Andy,

Am 13.01.23 um 22:53 schrieb Andy Shevchenko:
> The ->of_gpio_ranges_fallback() repeats the idea that lies behind
> ->add_pin_ranges(), while the latter covers more cases that the former
> hook. Drop the former one for good.

i successful tested booting of this series with multi_v7_defconfig on 
Raspberry Pi 4 (with and without gpio-ranges in DTB):

Tested-by: Stefan Wahren <stefan.wahren@...e.com>

>
> Changelog v3:
> - moved check of the property presense to GPIO library
> - split out the refcount fix in a separate patch
> - added cover letter
>
> Andy Shevchenko (4):
>    gpiolib: Check "gpio-ranges" before calling ->add_pin_ranges()
>    pinctrl: bcm2835: Remove of_node_put() in
>      bcm2835_of_gpio_ranges_fallback()
>    pinctrl: bcm2835: Switch to use ->add_pin_ranges()
>    Revert "gpiolib: of: Introduce hook for missing gpio-ranges"
>
>   drivers/gpio/gpiolib-of.c             |  5 -----
>   drivers/gpio/gpiolib.c                |  8 ++++++++
>   drivers/pinctrl/bcm/pinctrl-bcm2835.c | 10 ++++------
>   include/linux/gpio/driver.h           | 12 ------------
>   4 files changed, 12 insertions(+), 23 deletions(-)
>