linux-kernel - Re: [PATCH net-next v3 2/2] net: ethernet: ti: am65-cpsw/cpts: Fix CPTS release action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 19 Jan 2023 14:06:26 +0100
From:   Paolo Abeni <pabeni@...hat.com>
To:     Siddharth Vadapalli <s-vadapalli@...com>, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, linux@...linux.org.uk,
        rogerq@...nel.org, leon@...nel.org
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, vigneshr@...com, srk@...com
Subject: Re: [PATCH net-next v3 2/2] net: ethernet: ti: am65-cpsw/cpts: Fix
 CPTS release action

Hi,

On Wed, 2023-01-18 at 15:24 +0530, Siddharth Vadapalli wrote:
> @@ -1014,18 +1013,12 @@ struct am65_cpts *am65_cpts_create(struct device *dev, void __iomem *regs,
>  	}
>  	cpts->phc_index = ptp_clock_index(cpts->ptp_clock);
>  
> -	ret = devm_add_action_or_reset(dev, am65_cpts_release, cpts);
> -	if (ret) {
> -		dev_err(dev, "failed to add ptpclk reset action %d", ret);
> -		return ERR_PTR(ret);
> -	}
> -
>  	ret = devm_request_threaded_irq(dev, cpts->irq, NULL,
>  					am65_cpts_interrupt,
>  					IRQF_ONESHOT, dev_name(dev), cpts);
>  	if (ret < 0) {
>  		dev_err(cpts->dev, "error attaching irq %d\n", ret);
> -		return ERR_PTR(ret);
> +		goto reset_ptpclk;
>  	}
>  
>  	dev_info(dev, "CPTS ver 0x%08x, freq:%u, add_val:%u\n",

This chunk does not apply cleanly to current net-next (context is
changed). Please rebase and re-spin (you can preserve/keep the already
acquire reviewed-by tags)

Thanks!

Paolo