[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y8lMJI+SnnfxVMVe@lunn.ch>
Date: Thu, 19 Jan 2023 14:56:52 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Ahmad Fatoum <a.fatoum@...gutronix.de>
Cc: Jakub Kicinski <kuba@...nel.org>,
Woojung Huh <woojung.huh@...rochip.com>,
UNGLinuxDriver@...rochip.com,
Florian Fainelli <f.fainelli@...il.com>,
Vladimir Oltean <olteanv@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Arun Ramadoss <arun.ramadoss@...rochip.com>,
kernel@...gutronix.de, Oleksij Rempel <ore@...gutronix.de>,
Eric Dumazet <edumazet@...gle.com>,
Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: dsa: microchip: fix probe of I2C-connected
KSZ8563
On Thu, Jan 19, 2023 at 02:10:15PM +0100, Ahmad Fatoum wrote:
> Starting with commit eee16b147121 ("net: dsa: microchip: perform the
> compatibility check for dev probed"), the KSZ switch driver now bails
> out if it thinks the DT compatible doesn't match the actual chip:
>
> ksz9477-switch 1-005f: Device tree specifies chip KSZ9893 but found
> KSZ8563, please fix it!
>
> Problem is that the "microchip,ksz8563" compatible is associated
> with ksz_switch_chips[KSZ9893]. Same issue also affected the SPI driver
> for the same switch chip and was fixed in commit b44908095612
> ("net: dsa: microchip: add separate struct ksz_chip_data for KSZ8563 chip").
>
> Reuse ksz_switch_chips[KSZ8563] introduced in aforementioned commit
> to get I2C-connected KSZ8563 probing again.
>
> Fixes: eee16b147121 ("net: dsa: microchip: perform the compatibility check for dev probed")
> Signed-off-by: Ahmad Fatoum <a.fatoum@...gutronix.de>
Reviewed-by: Andrew Lunn <andrew@...n.ch>
Andrew
Powered by blists - more mailing lists