linux-kernel - Re: [PATCH net] net: dsa: microchip: fix probe of I2C-connected KSZ8563

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 20 Jan 2023 07:01:19 +0000
From:   <Arun.Ramadoss@...rochip.com>
To:     <olteanv@...il.com>, <UNGLinuxDriver@...rochip.com>,
        <andrew@...n.ch>, <f.fainelli@...il.com>, <kuba@...nel.org>,
        <a.fatoum@...gutronix.de>, <Woojung.Huh@...rochip.com>,
        <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel@...gutronix.de>, <pabeni@...hat.com>, <ore@...gutronix.de>,
        <edumazet@...gle.com>
Subject: Re: [PATCH net] net: dsa: microchip: fix probe of I2C-connected
 KSZ8563

Hi Ahmad,
On Thu, 2023-01-19 at 14:10 +0100, Ahmad Fatoum wrote:
> [You don't often get email from a.fatoum@...gutronix.de. Learn why
> this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> Starting with commit eee16b147121 ("net: dsa: microchip: perform the
> compatibility check for dev probed"), the KSZ switch driver now bails
> out if it thinks the DT compatible doesn't match the actual chip:
> 
>   ksz9477-switch 1-005f: Device tree specifies chip KSZ9893 but found
>   KSZ8563, please fix it!
> 
> Problem is that the "microchip,ksz8563" compatible is associated
> with ksz_switch_chips[KSZ9893]. Same issue also affected the SPI
> driver
> for the same switch chip and was fixed in commit b44908095612
> ("net: dsa: microchip: add separate struct ksz_chip_data for KSZ8563
> chip").
> 
> Reuse ksz_switch_chips[KSZ8563] introduced in aforementioned commit
> to get I2C-connected KSZ8563 probing again.
> 
> Fixes: eee16b147121 ("net: dsa: microchip: perform the compatibility
> check for dev probed")

In this commit, there is no KSZ8563 member in struct ksz_switch_chips.
Whether the fixes should be to this commit "net: dsa: microchip: add
separate struct ksz_chip_data for KSZ8563" where the member is
introduced.

> chip
> Signed-off-by: Ahmad Fatoum <a.fatoum@...gutronix.de>
> ---
>  drivers/net/dsa/microchip/ksz9477_i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/dsa/microchip/ksz9477_i2c.c
> b/drivers/net/dsa/microchip/ksz9477_i2c.c
> index c1a633ca1e6d..e315f669ec06 100644
> --- a/drivers/net/dsa/microchip/ksz9477_i2c.c
> +++ b/drivers/net/dsa/microchip/ksz9477_i2c.c
> @@ -104,7 +104,7 @@ static const struct of_device_id ksz9477_dt_ids[]
> = {
>         },
>         {
>                 .compatible = "microchip,ksz8563",
> -               .data = &ksz_switch_chips[KSZ9893]
> +               .data = &ksz_switch_chips[KSZ8563]
>         },
>         {
>                 .compatible = "microchip,ksz9567",
> --
> 2.30.2
>