linux-kernel - Re: [PATCH] ARM: dts: qcom: apq8060-dragonboard: align MPP pin node names with DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9821623b-fcca-2a3a-1cd6-9e95c480b1a4@linaro.org>
Date:   Fri, 20 Jan 2023 19:58:31 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: qcom: apq8060-dragonboard: align MPP pin node
 names with DT schema



On 20.01.2023 18:40, Krzysztof Kozlowski wrote:
> DT schema expects nodes ending with "pins:
> 
>   qcom-apq8060-dragonboard.dtb: mpps@50: cm3605-mpps-state: 'oneOf' conditional failed, one must be fixed:
>     'mpp5' does not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad
> 
> Warning visible after:
> https://lore.kernel.org/r/20230120165103.1278852-1-robh@kernel.org
> ---
>  arch/arm/boot/dts/qcom-apq8060-dragonboard.dts | 16 +++++++---------
>  1 file changed, 7 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
> index 7a4c59e04af6..8e4b61e4d4b1 100644
> --- a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
> +++ b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
> @@ -435,15 +435,13 @@ &pm8058_led133 {
>  
>  &pm8058_mpps {
>  	dragon_cm3605_mpps: cm3605-mpps-state {
> -		mpp5 {
> -			pins = "mpp5";
> -			function = "analog";
> -			input-enable;
> -			bias-high-impedance;
> -			/* Let's use channel 5 */
> -			qcom,amux-route = <PMIC_MPP_AMUX_ROUTE_CH5>;
> -			power-source = <PM8058_GPIO_S3>;
> -		};
> +		pins = "mpp5";
> +		function = "analog";
> +		input-enable;
> +		bias-high-impedance;
> +		/* Let's use channel 5 */
> +		qcom,amux-route = <PMIC_MPP_AMUX_ROUTE_CH5>;
> +		power-source = <PM8058_GPIO_S3>;
>  	};
>  };
>