linux-kernel - Re: [PATCH v1 1/1] cifs: Get rid of unneeded conditional in the smb2_get_aead

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH2r5mvgSnVhLSx=sjAu=dK1C5q9tqby-EmSz6_3rp+Azw-hKg@mail.gmail.com>
Date:   Fri, 20 Jan 2023 13:17:47 -0600
From:   Steve French <smfrench@...il.com>
To:     Paulo Alcantara <pc@....nz>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Steve French <stfrench@...rosoft.com>,
        linux-cifs@...r.kernel.org, samba-technical@...ts.samba.org,
        linux-kernel@...r.kernel.org, Steve French <sfrench@...ba.org>,
        Tom Talpey <tom@...pey.com>,
        Shyam Prasad N <sprasad@...rosoft.com>,
        Ronnie Sahlberg <lsahlber@...hat.com>
Subject: Re: [PATCH v1 1/1] cifs: Get rid of unneeded conditional in the smb2_get_aead_req()

merged into cifs-2.6.git for-next

On Fri, Jan 20, 2023 at 8:22 AM Paulo Alcantara via samba-technical
<samba-technical@...ts.samba.org> wrote:
>
> Andy Shevchenko <andriy.shevchenko@...ux.intel.com> writes:
>
> > In the smb2_get_aead_req() the skip variable is used only for
> > the very first iteration of the two nested loops, which means
> > it's basically in invariant to those loops. Hence, instead of
> > using conditional on each iteration, unconditionally assing
> > the 'skip' variable before the loops and at the end of the
> > inner loop.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > ---
> >  fs/cifs/smb2ops.c | 14 +++++++++-----
> >  1 file changed, 9 insertions(+), 5 deletions(-)
>
> Reviewed-by: Paulo Alcantara (SUSE) <pc@....nz>
>


-- 
Thanks,

Steve