linux-kernel - Re: [PATCH v1 1/1] cifs: Get rid of unneeded conditional in the smb2_get_aead

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r0vpe182.fsf@cjr.nz>
Date:   Fri, 20 Jan 2023 11:21:01 -0300
From:   Paulo Alcantara <pc@....nz>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Steve French <stfrench@...rosoft.com>,
        linux-cifs@...r.kernel.org, samba-technical@...ts.samba.org,
        linux-kernel@...r.kernel.org
Cc:     Steve French <sfrench@...ba.org>,
        Ronnie Sahlberg <lsahlber@...hat.com>,
        Shyam Prasad N <sprasad@...rosoft.com>,
        Tom Talpey <tom@...pey.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH v1 1/1] cifs: Get rid of unneeded conditional in the
 smb2_get_aead_req()

Andy Shevchenko <andriy.shevchenko@...ux.intel.com> writes:

> In the smb2_get_aead_req() the skip variable is used only for
> the very first iteration of the two nested loops, which means
> it's basically in invariant to those loops. Hence, instead of
> using conditional on each iteration, unconditionally assing
> the 'skip' variable before the loops and at the end of the
> inner loop.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  fs/cifs/smb2ops.c | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)

Reviewed-by: Paulo Alcantara (SUSE) <pc@....nz>