linux-kernel - Re: [PATCH] dt-bindings: pinctrl: qcom,pmic-mpp: Restrict 'mpp' child node name pattern

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3aa54a61-8a42-6ddf-d524-c20dc03111fa@linaro.org>
Date:   Fri, 20 Jan 2023 07:38:28 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh@...nel.org>
Cc:     Andy Gross <agross@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: pinctrl: qcom,pmic-mpp: Restrict 'mpp' child
 node name pattern

On 20/01/2023 05:29, Bjorn Andersson wrote:
> On Thu, Jan 19, 2023 at 08:06:00PM -0600, Rob Herring wrote:
>> Just 'mpp' is a bit ambiguous for a pattern. It allows any prefix or
>> suffix. I couldn't find any actual users, so update the pattern to match
>> the example.
>>
>> Signed-off-by: Rob Herring <robh@...nel.org>
>> ---
>>  Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
>> index 72cce38bc1ce..891a7385d7cb 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
>> @@ -74,7 +74,7 @@ patternProperties:
>>      oneOf:
>>        - $ref: "#/$defs/qcom-pmic-mpp-state"
>>        - patternProperties:
>> -          "mpp":
>> +          "-mpp$":
> 
> How about aligning it with the other Qualcomm pinctrl bindings and make
> it "-pins$" instead?
> 
> If my grep is correct we have one "mpp5" and two "-pins$" currently in
> the sources, so this should be beneficial as well.

Let's align it with other Qualcomm pinctrl bindings, so:
	"-pins$":

I can also fix the DTS to match it.

Best regards,
Krzysztof