linux-kernel - Re: [PATCH v6 09/10] arm64: dts: qcom: sc7180: Add support for HDCP in dp-controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7116584e-f5a1-f404-8cfc-d1d159a4d647@linaro.org>
Date:   Sat, 21 Jan 2023 12:16:21 +0200
From:   Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To:     Sean Paul <sean@...rly.run>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Mark Yacoub <markyacoub@...omium.org>, quic_khsieh@...cinc.com,
        linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        freedreno@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, intel-gfx@...ts.freedesktop.org,
        robdclark@...il.com, quic_abhinavk@...cinc.com, airlied@...il.com,
        daniel@...ll.ch, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, agross@...nel.org,
        andersson@...nel.org, konrad.dybcio@...ainline.org,
        jani.nikula@...ux.intel.com, joonas.lahtinen@...ux.intel.com,
        rodrigo.vivi@...el.com, tvrtko.ursulin@...ux.intel.com,
        tzimmermann@...e.de, ville.syrjala@...ux.intel.com,
        stanislav.lisovskiy@...el.com, matthew.d.roper@...el.com,
        imre.deak@...el.com, lucas.demarchi@...el.com,
        manasi.d.navare@...el.com, swati2.sharma@...el.com,
        bhanuprakash.modem@...el.com, javierm@...hat.com,
        jose.souza@...el.com, lyude@...hat.com, hbh25y@...il.com,
        arun.r.murthy@...el.com, ashutosh.dixit@...el.com,
        ankit.k.nautiyal@...el.com, maxime@...no.tech, swboyd@...omium.org,
        christophe.jaillet@...adoo.fr, quic_sbillaka@...cinc.com,
        johan+linaro@...nel.org, dianders@...omium.org, marex@...x.de,
        quic_jesszhan@...cinc.com, bjorn.andersson@...aro.org,
        abhinavk@...eaurora.org, seanpaul@...omium.org
Subject: Re: [PATCH v6 09/10] arm64: dts: qcom: sc7180: Add support for HDCP
 in dp-controller

On 20/01/2023 17:54, Sean Paul wrote:
> On Thu, Jan 19, 2023 at 11:35:32AM +0100, Krzysztof Kozlowski wrote:
>> On 18/01/2023 20:30, Mark Yacoub wrote:
>>> From: Sean Paul <seanpaul@...omium.org>
>>>
>>> This patch adds the register ranges required for HDCP key injection and
>>
>> Do not use "This commit/patch".
>> https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
>>
>> This applies to all your patches. Fix it everywhere.
> 
> My goodness, this is peak bikeshedding. Surely we have better things to do with
> our time?

While I would not enforce this rule if there were no other issues with 
the commits, Mark will have to cleanup/rework commits anyway, see other 
review comments. Thus removing/slightly rephrasing a commit message 
sounds like a minor issue to me.

>>>
>>> Signed-off-by: Sean Paul <seanpaul@...omium.org>
>>> Signed-off-by: Mark Yacoub <markyacoub@...omium.org>
>>> Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-15-sean@poorly.run #v1
>>> Link: https://patchwork.freedesktop.org/patch/msgid/20210915203834.1439-14-sean@poorly.run #v2
>>> Link: https://patchwork.freedesktop.org/patch/msgid/20211001151145.55916-14-sean@poorly.run #v3
>>> Link: https://patchwork.freedesktop.org/patch/msgid/20211105030434.2828845-14-sean@poorly.run #v4
>>> Link: https://patchwork.freedesktop.org/patch/msgid/20220411204741.1074308-10-sean@poorly.run #v5
>>
>> Drop the links.
> 
> Why? I've always done this, it seems helpful to me?
> 

I'd say, if you wish to include them, they belong to the cover letter, 
not to the per-commit message. Once landed, they will serve no purpose.

-- 
With best wishes
Dmitry