linux-kernel - Re: [PATCH 3/5] dt-bindings: iio: correct node names in examples

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230121171709.5eb75e94@jic23-huawei>
Date:   Sat, 21 Jan 2023 17:17:09 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Lucas Stankus <lucas.p.stankus@...il.com>,
        Puranjay Mohan <puranjay12@...il.com>,
        Dmitry Rokosov <ddrokosov@...rdevices.ru>,
        Alexandru Tachici <alexandru.tachici@...log.com>,
        Marcelo Schmitt <marcelo.schmitt1@...il.com>,
        Renato Lui Geh <renatogeh@...il.com>,
        Eugen Hristev <eugen.hristev@...rochip.com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        Andreas Klinger <ak@...klinger.de>,
        Marcus Folkesson <marcus.folkesson@...il.com>,
        Kent Gustavsson <kent@...oris.se>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Oleksij Rempel <linux@...pel-privat.de>, kernel@...gutronix.de,
        Nuno Sá <nuno.sa@...log.com>,
        Nishant Malpani <nish.malpani25@...il.com>,
        Rui Miguel Silva <rmfrfs@...il.com>,
        Dragos Bogdan <dragos.bogdan@...log.com>,
        Jean-Baptiste Maneyrol <jmaneyrol@...ensense.com>,
        Lorenzo Bianconi <lorenzo@...nel.org>,
        Benson Leung <bleung@...omium.org>,
        Guenter Roeck <groeck@...omium.org>,
        Stefan Popa <stefan.popa@...log.com>,
        Robert Yang <decatf@...il.com>,
        Sean Nyekjaer <sean@...nix.com>,
        Artur Rojek <contact@...ur-rojek.eu>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Philippe Reynes <tremyfr@...oo.fr>,
        Alexandru Lazar <alazar@...rtmail.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Caleb Connolly <caleb.connolly@...aro.org>,
        Fabrice Gasnier <fabrice.gasnier@...s.st.com>,
        Stefan Agner <stefan@...er.ch>,
        Daniel Baluta <daniel.baluta@....com>,
        Harald Geyer <harald@...ib.org>,
        Eugene Zaikonnikov <ez@...ophonic.com>,
        Phil Reid <preid@...ctromag.com.au>,
        Matt Ranostay <matt.ranostay@...sulko.com>,
        Stephen Boyd <swboyd@...omium.org>,
        Sankar Velliangiri <navin@...umiz.com>,
        linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-fbdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-renesas-soc@...r.kernel.org,
        linux-samsung-soc@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        chrome-platform@...ts.linux.dev
Subject: Re: [PATCH 3/5] dt-bindings: iio: correct node names in examples

On Wed, 18 Jan 2023 19:44:11 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:

> Do not use underscores and unneeded suffixes (e.g. i2c0) in node name in
> examples.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---

> diff --git a/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml b/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml
> index 6c5ad426a016..12f75ddc4a70 100644
> --- a/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml
> +++ b/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml
> @@ -42,7 +42,7 @@ examples:
>          #address-cells = <1>;
>          #size-cells = <0>;
>  
> -        heart_mon@0 {
> +        heart-rate@0 {

These are both heart-rate and pulse oximeters so measure more than just
the rate (oxygen saturation in the blood). Reality is they actually
measure light absorption over time, but you can calculate an estimate
of both rate and oxygen saturation from that.

I don't really mind simplifying that to heart-rate, but wanted to
call this out for possible discussion.


>              compatible = "ti,afe4403";
>              reg = <0>;
>              spi-max-frequency = <10000000>;
> diff --git a/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml b/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml
> index c0e815d9999e..b334f3e356ad 100644
> --- a/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml
> +++ b/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml
> @@ -39,7 +39,7 @@ examples:
>          #address-cells = <1>;
>          #size-cells = <0>;
>  
> -        heart_mon@58 {
> +        heart-rate@58 {
>              compatible = "ti,afe4404";
>              reg = <0x58>;
>              tx-supply = <&vbat>;

The rest are all fine.  If no one comments I'll pick this up as it is in a few
days.

Jonathan