linux-kernel - Re: [PATCH 3/5] dt-bindings: iio: correct node names in examples

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 21 Jan 2023 19:31:23 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Lucas Stankus <lucas.p.stankus@...il.com>,
        Puranjay Mohan <puranjay12@...il.com>,
        Dmitry Rokosov <ddrokosov@...rdevices.ru>,
        Alexandru Tachici <alexandru.tachici@...log.com>,
        Marcelo Schmitt <marcelo.schmitt1@...il.com>,
        Renato Lui Geh <renatogeh@...il.com>,
        Eugen Hristev <eugen.hristev@...rochip.com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        Andreas Klinger <ak@...klinger.de>,
        Marcus Folkesson <marcus.folkesson@...il.com>,
        Kent Gustavsson <kent@...oris.se>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Oleksij Rempel <linux@...pel-privat.de>, kernel@...gutronix.de,
        Nuno Sá <nuno.sa@...log.com>,
        Nishant Malpani <nish.malpani25@...il.com>,
        Rui Miguel Silva <rmfrfs@...il.com>,
        Dragos Bogdan <dragos.bogdan@...log.com>,
        Jean-Baptiste Maneyrol <jmaneyrol@...ensense.com>,
        Lorenzo Bianconi <lorenzo@...nel.org>,
        Benson Leung <bleung@...omium.org>,
        Guenter Roeck <groeck@...omium.org>,
        Stefan Popa <stefan.popa@...log.com>,
        Robert Yang <decatf@...il.com>,
        Sean Nyekjaer <sean@...nix.com>,
        Artur Rojek <contact@...ur-rojek.eu>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Philippe Reynes <tremyfr@...oo.fr>,
        Alexandru Lazar <alazar@...rtmail.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Caleb Connolly <caleb.connolly@...aro.org>,
        Fabrice Gasnier <fabrice.gasnier@...s.st.com>,
        Stefan Agner <stefan@...er.ch>,
        Daniel Baluta <daniel.baluta@....com>,
        Harald Geyer <harald@...ib.org>,
        Eugene Zaikonnikov <ez@...ophonic.com>,
        Phil Reid <preid@...ctromag.com.au>,
        Matt Ranostay <matt.ranostay@...sulko.com>,
        Stephen Boyd <swboyd@...omium.org>,
        Sankar Velliangiri <navin@...umiz.com>,
        linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-fbdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-renesas-soc@...r.kernel.org,
        linux-samsung-soc@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        chrome-platform@...ts.linux.dev
Subject: Re: [PATCH 3/5] dt-bindings: iio: correct node names in examples

On 21/01/2023 18:17, Jonathan Cameron wrote:
> On Wed, 18 Jan 2023 19:44:11 +0100
> Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:
> 
>> Do not use underscores and unneeded suffixes (e.g. i2c0) in node name in
>> examples.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> ---
> 
>> diff --git a/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml b/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml
>> index 6c5ad426a016..12f75ddc4a70 100644
>> --- a/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml
>> +++ b/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml
>> @@ -42,7 +42,7 @@ examples:
>>          #address-cells = <1>;
>>          #size-cells = <0>;
>>  
>> -        heart_mon@0 {
>> +        heart-rate@0 {
> 
> These are both heart-rate and pulse oximeters so measure more than just
> the rate (oxygen saturation in the blood). Reality is they actually
> measure light absorption over time, but you can calculate an estimate
> of both rate and oxygen saturation from that.
> 
> I don't really mind simplifying that to heart-rate, but wanted to
> call this out for possible discussion.

They could be heart-mon. The fix is mostly around the underscore. I
don't have any arguments for changing it to heart-rate, thus we can go
with whatever you prefer.

Best regards,
Krzysztof