linux-kernel - Re: [PATCH v2 1/1] iio: adc: qcom-spmi-adc5: Fix the channel name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230123193059.27a1c1a7@jic23-huawei>
Date:   Mon, 23 Jan 2023 19:30:59 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Nuno Sá <nuno.sa@...log.com>,
        linux-arm-msm@...r.kernel.org, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Subject: Re: [PATCH v2 1/1] iio: adc: qcom-spmi-adc5: Fix the channel name

On Mon, 23 Jan 2023 14:02:51 +0200
Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> On Sun, Jan 22, 2023 at 05:24:41PM +0000, Jonathan Cameron wrote:
> > On Wed, 18 Jan 2023 12:06:23 +0200
> > Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> >   
> > > The node name can contain an address part which is unused
> > > by the driver. Moreover, this string is propagated into
> > > the userspace label, sysfs filenames *and breaking ABI*.
> > > 
> > > Cut the address part out before assigning the channel name.
> > > 
> > > Fixes: 4f47a236a23d ("iio: adc: qcom-spmi-adc5: convert to device properties")
> > > Reported-by: Marijn Suijten <marijn.suijten@...ainline.org>
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>  
> > 
> > LGTM, but given it will have ABI impact, I'd like to hear from 
> > Andy, Bjorn or Konrad as maintainers and /or Dmitry as someone
> > who has touched this driver fairly recently.  
> 
> Hmm... But this is to fix the ABI breakage. It means that the previous series
> by Nuno had broken it.
Absolutely agree. I plan to take the change. The risk that someone needs
to fix up their use of the broken ABI makes it worth a little more shouting
about than if we had caught it sooner.

Jonathan

> 
> > Mostly I want to be sure they know this exists before it causes surprise.  
>