linux-kernel - Re: [PATCH v2 1/1] iio: adc: qcom-spmi-adc5: Fix the channel name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 23 Jan 2023 18:04:53 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Marijn Suijten <marijn.suijten@...ainline.org>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Nuno Sá <nuno.sa@...log.com>,
        linux-arm-msm@...r.kernel.org, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Douglas Anderson <dianders@...omium.org>
Subject: Re: [PATCH v2 1/1] iio: adc: qcom-spmi-adc5: Fix the channel name



On 23.01.2023 18:01, Marijn Suijten wrote:
> On 2023-01-23 17:35:34, Konrad Dybcio wrote:
>> On 22.01.2023 18:24, Jonathan Cameron wrote:
>>> On Wed, 18 Jan 2023 12:06:23 +0200
>>> Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
>>>
>>>> The node name can contain an address part which is unused
>>>> by the driver. Moreover, this string is propagated into
>>>> the userspace label, sysfs filenames *and breaking ABI*.
>>>>
>>>> Cut the address part out before assigning the channel name.
>>>>
>>>> Fixes: 4f47a236a23d ("iio: adc: qcom-spmi-adc5: convert to device properties")
>>>> Reported-by: Marijn Suijten <marijn.suijten@...ainline.org>
>>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>>>
>>> LGTM, but given it will have ABI impact, I'd like to hear from 
>>> Andy, Bjorn or Konrad as maintainers and /or Dmitry as someone
>>> who has touched this driver fairly recently.
>> + Doug
>>
>> Unless the Chromium folks relied on the old names (they're the
>> only ones I can think of that actually could have tapped into
>> this), I say green light!
> 
> Can you clarify "old names"?  The ABI-broken ones after Nuno's patch
> with @xx suffix, or the orignal names (without @xx) before that, which
> this patch from Andy reverts back to?
Nuno's patch names, this is a fix for that but in a very unfortunate
event, they might have started using sysfs paths right when the
breakage happened.

Konrad
> 
> - Marijn