| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <d1743abc-3d9f-cdf4-dfbe-67aac4b1b8cd@kaod.org>
Date: Mon, 23 Jan 2023 14:10:05 +0100
From: Cédric Le Goater <clg@...d.org>
To: Amit Kumar Mahapatra <amit.kumar-mahapatra@....com>,
<broonie@...nel.org>, <miquel.raynal@...tlin.com>,
<richard@....at>, <vigneshr@...com>, <jic23@...nel.org>,
<tudor.ambarus@...rochip.com>, <pratyush@...nel.org>,
<sanju.mehta@....com>, <chin-ting_kuo@...eedtech.com>,
<kdasu.kdev@...il.com>, <f.fainelli@...il.com>,
<rjui@...adcom.com>, <sbranden@...adcom.com>,
<eajames@...ux.ibm.com>, <olteanv@...il.com>, <han.xu@....com>,
<john.garry@...wei.com>, <shawnguo@...nel.org>,
<s.hauer@...gutronix.de>, <narmstrong@...libre.com>,
<khilman@...libre.com>, <matthias.bgg@...il.com>,
<haibo.chen@....com>, <linus.walleij@...aro.org>,
<daniel@...que.org>, <haojian.zhuang@...il.com>,
<robert.jarzmik@...e.fr>, <agross@...nel.org>,
<bjorn.andersson@...aro.org>, <heiko@...ech.de>,
<krzysztof.kozlowski@...aro.org>, <andi@...zian.org>,
<mcoquelin.stm32@...il.com>, <alexandre.torgue@...s.st.com>,
<wens@...e.org>, <jernej.skrabec@...il.com>, <samuel@...lland.org>,
<masahisa.kojima@...aro.org>, <jaswinder.singh@...aro.org>,
<rostedt@...dmis.org>, <mingo@...hat.com>,
<l.stelmach@...sung.com>, <davem@...emloft.net>,
<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
<alex.aring@...il.com>, <stefan@...enfreihafen.org>,
<kvalo@...nel.org>, <thierry.reding@...il.com>,
<jonathanh@...dia.com>, <skomatineni@...dia.com>,
<sumit.semwal@...aro.org>, <christian.koenig@....com>,
<j.neuschaefer@....net>, <vireshk@...nel.org>, <rmfrfs@...il.com>,
<johan@...nel.org>, <elder@...nel.org>,
<gregkh@...uxfoundation.org>
CC: <git@....com>, <linux-spi@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <joel@....id.au>,
<andrew@...id.au>, <radu_nicolae.pirea@....ro>,
<nicolas.ferre@...rochip.com>, <alexandre.belloni@...tlin.com>,
<claudiu.beznea@...rochip.com>,
<bcm-kernel-feedback-list@...adcom.com>, <fancer.lancer@...il.com>,
<kernel@...gutronix.de>, <festevam@...il.com>, <linux-imx@....com>,
<jbrunet@...libre.com>, <martin.blumenstingl@...glemail.com>,
<avifishman70@...il.com>, <tmaimon77@...il.com>,
<tali.perry1@...il.com>, <venture@...gle.com>, <yuenn@...gle.com>,
<benjaminfair@...gle.com>, <yogeshgaur.83@...il.com>,
<konrad.dybcio@...ainline.org>, <alim.akhtar@...sung.com>,
<ldewangan@...dia.com>, <michal.simek@....com>,
<linux-aspeed@...ts.ozlabs.org>, <openbmc@...ts.ozlabs.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-rpi-kernel@...ts.infradead.org>,
<linux-amlogic@...ts.infradead.org>,
<linux-mediatek@...ts.infradead.org>,
<linux-arm-msm@...r.kernel.org>,
<linux-rockchip@...ts.infradead.org>,
<linux-samsung-soc@...r.kernel.org>,
<linux-stm32@...md-mailman.stormreply.com>,
<linux-sunxi@...ts.linux.dev>, <linux-tegra@...r.kernel.org>,
<netdev@...r.kernel.org>, <linux-wpan@...r.kernel.org>,
<libertas-dev@...ts.infradead.org>,
<linux-wireless@...r.kernel.org>, <linux-mtd@...ts.infradead.org>,
<lars@...afoo.de>, <Michael.Hennerich@...log.com>,
<linux-iio@...r.kernel.org>, <michael@...le.cc>,
<palmer@...belt.com>, <linux-riscv@...ts.infradead.org>,
<linux-media@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
<greybus-dev@...ts.linaro.org>, <linux-staging@...ts.linux.dev>,
<amitrkcian2002@...il.com>
Subject: Re: [PATCH v2 02/13] spi: Replace all spi->chip_select and
spi->cs_gpiod references with function call
On 1/19/23 19:53, Amit Kumar Mahapatra wrote:
> diff --git a/drivers/spi/spi-aspeed-smc.c b/drivers/spi/spi-aspeed-smc.c
> index 873ff2cf72c9..b7a9ec550ba1 100644
> --- a/drivers/spi/spi-aspeed-smc.c
> +++ b/drivers/spi/spi-aspeed-smc.c
> @@ -296,7 +296,7 @@ static const struct aspeed_spi_data ast2400_spi_data;
> static int do_aspeed_spi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op)
> {
> struct aspeed_spi *aspi = spi_controller_get_devdata(mem->spi->master);
> - struct aspeed_spi_chip *chip = &aspi->chips[mem->spi->chip_select];
> + struct aspeed_spi_chip *chip = &aspi->chips[spi_get_chipselect(mem->spi, 0)];
> u32 addr_mode, addr_mode_backup;
> u32 ctl_val;
> int ret = 0;
> @@ -377,7 +377,8 @@ static const char *aspeed_spi_get_name(struct spi_mem *mem)
> struct aspeed_spi *aspi = spi_controller_get_devdata(mem->spi->master);
> struct device *dev = aspi->dev;
>
> - return devm_kasprintf(dev, GFP_KERNEL, "%s.%d", dev_name(dev), mem->spi->chip_select);
> + return devm_kasprintf(dev, GFP_KERNEL, "%s.%d", dev_name(dev),
> + spi_get_chipselect(mem->spi, 0));
> }
>
> struct aspeed_spi_window {
> @@ -553,7 +554,7 @@ static int aspeed_spi_do_calibration(struct aspeed_spi_chip *chip);
> static int aspeed_spi_dirmap_create(struct spi_mem_dirmap_desc *desc)
> {
> struct aspeed_spi *aspi = spi_controller_get_devdata(desc->mem->spi->master);
> - struct aspeed_spi_chip *chip = &aspi->chips[desc->mem->spi->chip_select];
> + struct aspeed_spi_chip *chip = &aspi->chips[spi_get_chipselect(desc->mem->spi, 0)];
> struct spi_mem_op *op = &desc->info.op_tmpl;
> u32 ctl_val;
> int ret = 0;
> @@ -620,7 +621,7 @@ static ssize_t aspeed_spi_dirmap_read(struct spi_mem_dirmap_desc *desc,
> u64 offset, size_t len, void *buf)
> {
> struct aspeed_spi *aspi = spi_controller_get_devdata(desc->mem->spi->master);
> - struct aspeed_spi_chip *chip = &aspi->chips[desc->mem->spi->chip_select];
> + struct aspeed_spi_chip *chip = &aspi->chips[spi_get_chipselect(desc->mem->spi, 0)];
>
> /* Switch to USER command mode if mapping window is too small */
> if (chip->ahb_window_size < offset + len) {
> @@ -670,7 +671,7 @@ static int aspeed_spi_setup(struct spi_device *spi)
> {
> struct aspeed_spi *aspi = spi_controller_get_devdata(spi->master);
> const struct aspeed_spi_data *data = aspi->data;
> - unsigned int cs = spi->chip_select;
> + unsigned int cs = spi_get_chipselect(spi, 0);
> struct aspeed_spi_chip *chip = &aspi->chips[cs];
>
> chip->aspi = aspi;
> @@ -697,7 +698,7 @@ static int aspeed_spi_setup(struct spi_device *spi)
> static void aspeed_spi_cleanup(struct spi_device *spi)
> {
> struct aspeed_spi *aspi = spi_controller_get_devdata(spi->master);
> - unsigned int cs = spi->chip_select;
> + unsigned int cs = spi_get_chipselect(spi, 0);
>
> aspeed_spi_chip_enable(aspi, cs, false);
>
For the Aspeed driver,
Reviewed-by: Cédric Le Goater <clg@...d.org>
Thanks,
C.
Powered by blists - more mailing lists