linux-kernel - Re: [PATCH v2] thermal: int340x_thermal: Add production mode attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202301231356.x7cUwKr8-lkp@intel.com>
Date:   Mon, 23 Jan 2023 14:01:50 +0800
From:   kernel test robot <lkp@...el.com>
To:     Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        rafael@...nel.org, rui.zhang@...el.com, daniel.lezcano@...aro.org
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
Subject: Re: [PATCH v2] thermal: int340x_thermal: Add production mode
 attribute

Hi Srinivas,

I love your patch! Perhaps something to improve:

[auto build test WARNING on rafael-pm/thermal]
[also build test WARNING on linus/master v6.2-rc5 next-20230120]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Srinivas-Pandruvada/thermal-int340x_thermal-Add-production-mode-attribute/20230123-104105
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal
patch link:    https://lore.kernel.org/r/20230123024040.337866-1-srinivas.pandruvada%40linux.intel.com
patch subject: [PATCH v2] thermal: int340x_thermal: Add production mode attribute
config: x86_64-randconfig-a014-20230123 (https://download.01.org/0day-ci/archive/20230123/202301231356.x7cUwKr8-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/2c4e5f536a8e523a9f48701629806ecb63346cc0
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Srinivas-Pandruvada/thermal-int340x_thermal-Add-production-mode-attribute/20230123-104105
        git checkout 2c4e5f536a8e523a9f48701629806ecb63346cc0
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/thermal/intel/int340x_thermal/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/thermal/intel/int340x_thermal/int3400_thermal.c:351:6: warning: no previous prototype for function 'production_mode_exit' [-Wmissing-prototypes]
   void production_mode_exit(struct int3400_thermal_priv *priv)
        ^
   drivers/thermal/intel/int340x_thermal/int3400_thermal.c:351:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void production_mode_exit(struct int3400_thermal_priv *priv)
   ^
   static 
   1 warning generated.


vim +/production_mode_exit +351 drivers/thermal/intel/int340x_thermal/int3400_thermal.c

   350	
 > 351	void production_mode_exit(struct int3400_thermal_priv *priv)
   352	{
   353		if (priv->production_mode >= 0)
   354			sysfs_remove_file(&priv->pdev->dev.kobj, &dev_attr_production_mode.attr);
   355	}
   356	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests