linux-kernel - Re: [PATCH 1/8] eventfs: introducing struct tracefs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202301231332.yy4fecm8-lkp@intel.com>
Date:   Mon, 23 Jan 2023 14:01:49 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ajay Kaher <akaher@...are.com>, rostedt@...dmis.org,
        mhiramat@...nel.org
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        linux-trace-kernel@...r.kernel.org, chinglinyu@...gle.com,
        namit@...are.com, srivatsab@...are.com, srivatsa@...il.mit.edu,
        amakhalov@...are.com, vsirnapalli@...are.com, tkundu@...are.com,
        er.ajay.kaher@...il.com, Ajay Kaher <akaher@...are.com>
Subject: Re: [PATCH 1/8] eventfs: introducing struct tracefs_inode

Hi Ajay,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.2-rc5 next-20230120]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ajay-Kaher/eventfs-adding-eventfs-dir-add-functions/20230123-010956
patch link:    https://lore.kernel.org/r/1674407228-49109-1-git-send-email-akaher%40vmware.com
patch subject: [PATCH 1/8] eventfs: introducing struct tracefs_inode
config: x86_64-rhel-8.3-func (https://download.01.org/0day-ci/archive/20230123/202301231332.yy4fecm8-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/926ba0e4029baa4bbc7c283854148d1769642d50
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Ajay-Kaher/eventfs-adding-eventfs-dir-add-functions/20230123-010956
        git checkout 926ba0e4029baa4bbc7c283854148d1769642d50
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 olddefconfig
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> fs/tracefs/inode.c:130:15: warning: no previous prototype for 'tracefs_get_inode' [-Wmissing-prototypes]
     130 | struct inode *tracefs_get_inode(struct super_block *sb)
         |               ^~~~~~~~~~~~~~~~~
>> fs/tracefs/inode.c:402:16: warning: no previous prototype for 'tracefs_start_creating' [-Wmissing-prototypes]
     402 | struct dentry *tracefs_start_creating(const char *name, struct dentry *parent)
         |                ^~~~~~~~~~~~~~~~~~~~~~
>> fs/tracefs/inode.c:440:16: warning: no previous prototype for 'tracefs_failed_creating' [-Wmissing-prototypes]
     440 | struct dentry *tracefs_failed_creating(struct dentry *dentry)
         |                ^~~~~~~~~~~~~~~~~~~~~~~
>> fs/tracefs/inode.c:448:16: warning: no previous prototype for 'tracefs_end_creating' [-Wmissing-prototypes]
     448 | struct dentry *tracefs_end_creating(struct dentry *dentry)
         |                ^~~~~~~~~~~~~~~~~~~~


vim +/tracefs_get_inode +130 fs/tracefs/inode.c

   129	
 > 130	struct inode *tracefs_get_inode(struct super_block *sb)
   131	{
   132		struct inode *inode = new_inode(sb);
   133		if (inode) {
   134			inode->i_ino = get_next_ino();
   135			inode->i_atime = inode->i_mtime = inode->i_ctime = current_time(inode);
   136		}
   137		return inode;
   138	}
   139	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests