linux-kernel - Re: [PATCH v2] netfilter: conntrack: remote a return value of the 'seq_print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 23 Jan 2023 19:44:58 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Gavrilov Ilia <Ilia.Gavrilov@...otecs.ru>
Cc:     "coreteam@...filter.org" <coreteam@...filter.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "fw@...len.de" <fw@...len.de>, "joe@...ches.com" <joe@...ches.com>,
        "kadlec@...filter.org" <kadlec@...filter.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "lvc-project@...uxtesting.org" <lvc-project@...uxtesting.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "netfilter-devel@...r.kernel.org" <netfilter-devel@...r.kernel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "pablo@...filter.org" <pablo@...filter.org>
Subject: Re: [PATCH v2] netfilter: conntrack: remote a return value of the
 'seq_print_acct' function.

On Mon, Jan 23, 2023 at 02:31:54PM +0000, Gavrilov Ilia wrote:
> The static 'seq_print_acct' function always returns 0.
> 
> Change the return value to 'void' and remove unnecessary checks.
> 
> Found by InfoTeCS on behalf of Linux Verification Center
> (linuxtesting.org) with SVACE.
> 
> Fixes: 1ca9e41770cb ("netfilter: Remove uses of seq_<foo> return values")
> Signed-off-by: Ilia.Gavrilov <Ilia.Gavrilov@...otecs.ru>
> ---
> V2: Fix coding style
>  net/netfilter/nf_conntrack_standalone.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>