Message-ID: <20230125205123.GA2864330-robh@kernel.org>
Date:   Wed, 25 Jan 2023 14:51:23 -0600
From:   Rob Herring <robh@...nel.org>
To:     William Zhang <william.zhang@...adcom.com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Linux SPI List <linux-spi@...r.kernel.org>,
        Broadcom Kernel List <bcm-kernel-feedback-list@...adcom.com>,
        tomer.yacoby@...adcom.com, kursad.oney@...adcom.com,
        dregan@...l.com, f.fainelli@...il.com, anand.gore@...adcom.com,
        jonas.gorski@...il.com, dan.beygelman@...adcom.com,
        joel.peshkin@...adcom.com,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Mark Brown <broonie@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 02/14] dt-bindings: spi: Add bcmbca-hsspi controller
 support

On Wed, Jan 25, 2023 at 11:23:52AM -0800, William Zhang wrote:
> 
> 
> On 01/24/2023 11:35 PM, Krzysztof Kozlowski wrote:
> > On 24/01/2023 23:12, William Zhang wrote:
> > > The new Broadcom Broadband BCMBCA SoCs includes a updated HSSPI
> > > controller. Add new compatible strings to differentiate the old and new
> > > controller while keeping MIPS based chip with the old compatible. Update
> > > property requirements for these two revisions of the controller.  Also
> > > add myself and Kursad as the maintainers.
> > > 
> > > Signed-off-by: William Zhang <william.zhang@...adcom.com>
> > > 
> > > ---
> > > 
> > > Changes in v2:
> > > - Update new compatible string to follow Broadcom convention <chip
> > > specific compatible>, <version of the IP>, <fallback>
> > > - Add reg-names min/maxItem constraints to be consistent with reg
> > > property
> > > - Make interrupts required property
> > > - Remove double quote from spi-controller.yaml reference
> > > - Remove brcm,use-cs-workaround flag
> > > - Update the example with new compatile and interrupts property
> > > - Update commit message
> > > 
> > >   .../bindings/spi/brcm,bcm63xx-hsspi.yaml      | 106 +++++++++++++++++-
> > >   1 file changed, 101 insertions(+), 5 deletions(-)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/spi/brcm,bcm63xx-hsspi.yaml b/Documentation/devicetree/bindings/spi/brcm,bcm63xx-hsspi.yaml
> > > index d1a0c9adee7a..d39604654c9e 100644
> > > --- a/Documentation/devicetree/bindings/spi/brcm,bcm63xx-hsspi.yaml
> > > +++ b/Documentation/devicetree/bindings/spi/brcm,bcm63xx-hsspi.yaml
> > > @@ -4,20 +4,73 @@
> > >   $id: http://devicetree.org/schemas/spi/brcm,bcm63xx-hsspi.yaml#
> > >   $schema: http://devicetree.org/meta-schemas/core.yaml#
> > > -title: Broadcom BCM6328 High Speed SPI controller
> > > +title: Broadcom Broadband SoC High Speed SPI controller
> > >   maintainers:
> > > +
> > 
> > This is a friendly reminder during the review process.
> > 
> > It seems my previous comments were not fully addressed. Maybe my
> > feedback got lost between the quotes, maybe you just forgot to apply it.
> > Please go back to the previous discussion and either implement all
> > requested changes or keep discussing them.
> > 
> > Thank you.
> > 
> Yeah I forgot to remove the blank line after maintainers tag.  Also
> regarding the explanation of dummy cs workaround flag,  we decided to remove
> it as it is not necessary after discussion internally and with SPI
> maintainer Mark. Let me know if I missed anything else.
> 
> > > +  - William Zhang <william.zhang@...adcom.com>
> > > +  - Kursad Oney <kursad.oney@...adcom.com>
> > >     - Jonas Gorski <jonas.gorski@...il.com>
> > > -allOf:
> > > -  - $ref: spi-controller.yaml#
> > 
> > In your previous patch, put it already in desired place (after
> > "required:"), so you will not have to shuffle it.
> > 
> Will update the previous patch in v3
> 
> > > +description: |
> > > +  Broadcom Broadband SoC supports High Speed SPI master controller since the
> > > +  early MIPS based chips such as BCM6328 and BCM63268.  This initial rev 1.0
> > > +  controller was carried over to recent ARM based chips, such as BCM63138,
> > > +  BCM4908 and BCM6858. The old MIPS based chip should continue to use the
> > > +  brcm,bcm6328-hsspi compatible string. The recent ARM based chip is required to
> > > +  use the brcm,bcmbca-hsspi-v1.0 as part of its compatible string list as
> > > +  defined below to match the specific chip along with ip revision info.
> > > +
> > > +  This rev 1.0 controller has a limitation that can not keep the chip select line
> > > +  active between the SPI transfers within the same SPI message. This can
> > > +  terminate the transaction to some SPI devices prematurely. The issue can be
> > > +  worked around by either the controller's prepend mode or using the dummy chip
> > > +  select workaround. Driver automatically picks the suitable mode based on
> > > +  transfer type so it is transparent to the user.
> > > +
> > > +  The newer SoCs such as BCM6756, BCM4912 and BCM6855 include an updated SPI
> > > +  controller rev 1.1 that add the capability to allow the driver to control chip
> > > +  select explicitly. This solves the issue in the old controller.
> > >   properties:
> > >     compatible:
> > > -    const: brcm,bcm6328-hsspi
> > > +    oneOf:
> > > +      - const: brcm,bcm6328-hsspi
> > > +      - items:
> > > +          - enum:
> > > +              - brcm,bcm47622-hsspi
> > > +              - brcm,bcm4908-hsspi
> > > +              - brcm,bcm63138-hsspi
> > > +              - brcm,bcm63146-hsspi
> > > +              - brcm,bcm63148-hsspi
> > > +              - brcm,bcm63158-hsspi
> > > +              - brcm,bcm63178-hsspi
> > > +              - brcm,bcm6846-hsspi
> > > +              - brcm,bcm6856-hsspi
> > > +              - brcm,bcm6858-hsspi
> > > +              - brcm,bcm6878-hsspi
> > > +          - const: brcm,bcmbca-hsspi-v1.0
> > > +          - const: brcm,bcmbca-hsspi
> > 
> > Why do you need "brcm,bcmbca-hsspi"? Nothing binds to it, so it's
> > useless and very generic.
> > 
> This was from Florian's suggestion and Broadcom's convention. See [1] and
> you are okay with that [2].  I added the rev compatible and you were not
> objecting it finally if I understand you correctly.

Can you have a driver that only understands what 'brcm,bcmbca-hsspi' is 
work on all h/w that includes the compatible string? It doesn't seem 
like it since v1.1 is a completely new driver. Therefore 
'brcm,bcmbca-hsspi' is pretty much useless.

Really, your 'generic' fallback for v1.0 should be 'brcm,bcm6328-hsspi' 
because that is the one the OS already supports. I don't know why folks 
get so hung up on saying new SoC block is compatible with old SoC's 
block.

The rule on using version numbers is they must correspond to something. 
FPGA soft IP with released versions is a good example. I always suspect 
a v1 or v1.0 is made up by the binding author.

Rob

Powered by blists - more mailing lists