linux-kernel - Re: [PATCH 5/5] ARM: dts: qcom: msm8974-oneplus-bacon: Add notification LED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4455893.LvFx2qVVIh@g550jk>
Date:   Wed, 25 Jan 2023 21:51:21 +0100
From:   Luca Weiss <luca@...tu.xyz>
To:     ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] ARM: dts: qcom: msm8974-oneplus-bacon: Add notification LED

On Montag, 23. Jänner 2023 18:18:16 CET Krzysztof Kozlowski wrote:
> On 22/01/2023 17:48, Luca Weiss wrote:
> > Add the node describing the sn3193 that's used to provide notification
> > LED.
> > 
> > Unfortunately the driver currently supports neither multicolor API nor
> > using the properties function & color, so we use label instead.
> > 
> > Signed-off-by: Luca Weiss <luca@...tu.xyz>
> > ---
> > 
> >  .../arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts | 28
> >  ++++++++++++++++++++++ 1 file changed, 28 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts
> > b/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts index
> > ffb486ceb6a6..a672c45d7070 100644
> > --- a/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts
> > +++ b/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts
> > @@ -114,6 +114,34 @@ led@0 {
> > 
> >  			default-brightness = <80>;
> >  		
> >  		};
> >  	
> >  	};
> > 
> > +
> > +	led-controller@68 {
> > +		compatible = "si-en,sn3193";
> > +		reg = <0x68>;
> > +
> > +		shutdown-gpios = <&tlmm 45 GPIO_ACTIVE_HIGH>;
> > +
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +
> > +		led@1 {
> > +			reg = <1>;
> > +			label = "red:status";
> 
> These should be colors and functions.

Hi Krzysztof,

please check the commit message for this. I tried using it but it didn't work, 
the driver in general might need an overhaul at some point...

> Unfortunately the driver currently supports neither multicolor API nor
> using the properties function & color, so we use label instead.

Or maybe I messed up but pretty sure this was the case when I wrote the dts.

Regards
Luca

> 
> 
> Best regards,
> Krzysztof