linux-kernel - Re: [PATCH 1/5] arm: dts: mt7623: add gmacs to mt7623.dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ab1b3d2-f9fd-e64d-6346-1d80e7f57dba@arinc9.com>
Date:   Wed, 25 Jan 2023 19:52:21 +0300
From:   Arınç ÜNAL <arinc.unal@...nc9.com>
To:     frank-w@...lic-files.de, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Matthias Brugger <matthias.bgg@...il.com>
Cc:     devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        erkin.bozoglu@...ont.com, Sean Wang <sean.wang@...iatek.com>,
        DENG Qingfang <dqfext@...il.com>
Subject: Re: [PATCH 1/5] arm: dts: mt7623: add gmacs to mt7623.dtsi

On 25.01.2023 19:45, Frank Wunderlich wrote:
> Am 20. Januar 2023 21:53:14 MEZ schrieb "Arınç ÜNAL" <arinc.unal@...nc9.com>:
> 
>> index 25d31e40a553..5eb698a90d34 100644
>> --- a/arch/arm/boot/dts/mt7623.dtsi
>> +++ b/arch/arm/boot/dts/mt7623.dtsi
>> @@ -981,6 +981,20 @@ eth: ethernet@...00000 {
>> 		#address-cells = <1>;
>> 		#size-cells = <0>;
>> 		status = "disabled";
>> +
>> +		gmac0: mac@0 {
>> +			compatible = "mediatek,eth-mac";
>> +			reg = <0>;
>> +			phy-mode = "trgmii";
>> +			status = "disabled";
>> +		};
>> +
>> +		gmac1: mac@1 {
>> +			compatible = "mediatek,eth-mac";
>> +			reg = <1>;
>> +			phy-mode = "rgmii";
>> +			status = "disabled";
>> +		};
>> 	};
>>
> 
>> diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
>> index 5008115d2494..a5800a524302 100644
>> --- a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
>> +++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
>> @@ -175,9 +175,7 @@ &eth {
>> 	status = "okay";
>>
>> 	gmac0: mac@0 {
> 
> Should node not be accessed with label (&gmac0) instead of defining it again and shadow the one from dtsi?

I think that's up to preference. I kept it the current way as it's 
cleaner than taking it out of &eth.

Arınç