linux-kernel - Re: [PATCH v3] gpiolib: fix linker errors when GPIOLIB is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y9FzTGxX5Z+XsTHV@smile.fi.intel.com>
Date:   Wed, 25 Jan 2023 20:22:04 +0200
From:   Andy Shevchenko <andriy.shevchenko@...el.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Pierluigi Passaro <pierluigi.p@...iscite.com>,
        linus.walleij@...aro.org, yamada.masahiro@...ionext.com,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        sfr@...b.auug.org.au, eran.m@...iscite.com, nate.d@...iscite.com,
        francesco.f@...iscite.com, pierluigi.passaro@...il.com,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v3] gpiolib: fix linker errors when GPIOLIB is disabled

On Tue, Jan 24, 2023 at 09:54:54AM +0100, Bartosz Golaszewski wrote:
> On Tue, Jan 24, 2023 at 2:31 AM Pierluigi Passaro
> <pierluigi.p@...iscite.com> wrote:

...

> >  #else /* CONFIG_GPIOLIB */
> >
> > +#include <linux/gpio/machine.h>
> > +#include <linux/gpio/consumer.h>
> 
> Please move those headers to the top and arrange them alphabetically
> with the rest of the <linux/ headers. Since you're now including
> those, remove any forward declarations of the types in question.

That's not correct way. The headers will make the whole purpose of splitting
(between driver, machine, and consumer) useless.

Lemme look at it, but I believe the solution is not so simple.
We need to clean up header inclusions as we did for pin control.

-- 
With Best Regards,
Andy Shevchenko