linux-kernel - Re: [PATCH v3] gpiolib: fix linker errors when GPIOLIB is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y9F79GvU1a+CjmLr@smile.fi.intel.com>
Date:   Wed, 25 Jan 2023 20:59:00 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Pierluigi Passaro <pierluigi.p@...iscite.com>
Cc:     linus.walleij@...aro.org, brgl@...ev.pl,
        yamada.masahiro@...ionext.com, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, sfr@...b.auug.org.au,
        eran.m@...iscite.com, nate.d@...iscite.com,
        francesco.f@...iscite.com, pierluigi.passaro@...il.com,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v3] gpiolib: fix linker errors when GPIOLIB is disabled

On Tue, Jan 24, 2023 at 02:31:38AM +0100, Pierluigi Passaro wrote:
> Both the functions gpiochip_request_own_desc and
> gpiochip_free_own_desc are exported from
>     drivers/gpio/gpiolib.c
> but this file is compiled only when CONFIG_GPIOLIB is enabled.
> Move the prototypes under "#ifdef CONFIG_GPIOLIB" and provide
> reasonable definitions and includes in the "#else" branch.

So far as a quick fix I can agree on the change with a caveat that inclusion
hell should be untangled in the future.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

P.S. The root cause of this problem is that some drivers without being GPIO chips
abuse this API. Better fix can be to go through each of such drivers and add ugly
ifdeffery with a FIXME comment that this shouldn't be actually used to begin with.

> Fixes: 9091373ab7ea ("gpio: remove less important #ifdef around declarations")
> Signed-off-by: Pierluigi Passaro <pierluigi.p@...iscite.com>
> Reported-by: kernel test robot <lkp@...el.com>
> ---
> Changes in v2:
> - add Fixes tag
> Changes in v3:
> - add includes to fix builds against x86_64-defconfig
> 
>  include/linux/gpio/driver.h | 23 +++++++++++++++++++++--
>  1 file changed, 21 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
> index 44783fc16125..e00eaba724dc 100644
> --- a/include/linux/gpio/driver.h
> +++ b/include/linux/gpio/driver.h
> @@ -758,6 +758,8 @@ gpiochip_remove_pin_ranges(struct gpio_chip *gc)
>  
>  #endif /* CONFIG_PINCTRL */
>  
> +#ifdef CONFIG_GPIOLIB
> +
>  struct gpio_desc *gpiochip_request_own_desc(struct gpio_chip *gc,
>  					    unsigned int hwnum,
>  					    const char *label,
> @@ -765,8 +767,6 @@ struct gpio_desc *gpiochip_request_own_desc(struct gpio_chip *gc,
>  					    enum gpiod_flags dflags);
>  void gpiochip_free_own_desc(struct gpio_desc *desc);
>  
> -#ifdef CONFIG_GPIOLIB
> -
>  /* lock/unlock as IRQ */
>  int gpiochip_lock_as_irq(struct gpio_chip *gc, unsigned int offset);
>  void gpiochip_unlock_as_irq(struct gpio_chip *gc, unsigned int offset);
> @@ -776,6 +776,25 @@ struct gpio_chip *gpiod_to_chip(const struct gpio_desc *desc);
>  
>  #else /* CONFIG_GPIOLIB */
>  
> +#include <linux/gpio/machine.h>
> +#include <linux/gpio/consumer.h>
> +
> +static inline struct gpio_desc *gpiochip_request_own_desc(struct gpio_chip *gc,
> +					    unsigned int hwnum,
> +					    const char *label,
> +					    enum gpio_lookup_flags lflags,
> +					    enum gpiod_flags dflags)
> +{
> +	/* GPIO can never have been requested */
> +	WARN_ON(1);
> +	return ERR_PTR(-ENODEV);
> +}
> +
> +static inline void gpiochip_free_own_desc(struct gpio_desc *desc)
> +{
> +	WARN_ON(1);
> +}
> +
>  static inline struct gpio_chip *gpiod_to_chip(const struct gpio_desc *desc)
>  {
>  	/* GPIO can never have been requested */
> -- 
> 2.34.1
> 
> 

-- 
With Best Regards,
Andy Shevchenko