linux-kernel - Re: [PATCH 0/3] selftests/tracing: Fix some testcases for recent change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <350d21a9-ac48-7da8-aa5e-d51ad794730a@linuxfoundation.org>
Date:   Thu, 26 Jan 2023 13:43:13 -0700
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Steven Rostedt <rostedt@...dmis.org>,
        "Masami Hiramatsu (Google)" <mhiramat@...nel.org>
Cc:     Shuah Khan <shuah@...nel.org>, linux-kernel@...r.kernel.org,
        linux-trace-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH 0/3] selftests/tracing: Fix some testcases for recent
 change

On 1/8/23 14:31, Steven Rostedt wrote:
> On Sat,  7 Jan 2023 22:32:08 +0900
> "Masami Hiramatsu (Google)" <mhiramat@...nel.org> wrote:
> 
>> This includes some patches to fix 2 issues on ftrace selftests.
>>
>> - eprobe filter and eprobe syntax test case were introduced but it
>>    doesn't check whether the kernel supports eprobe filter. Thus the
>>    new test case fails on the kernel which has eprobe but not support
>>    eprobe filter. To solve this issue, add a filter description to
>>    README file [1/3] and run the filter syntax error test only if the
>>    description is found in the README file [2/3].
>>
>> - Recently objtool adds prefix symbols for the function padding nops,
>>    and the probepoint test case fails because this probepoint test case
>>    tests whether the kprobe event can probe the target function and the
>>    functions next to the target function. But the prefix symbols can not
>>    be probed. Thus these prefix symbols must be skipped [3/3].
>>
>> Thank you,
>>
>> ---
>>
>> Masami Hiramatsu (Google) (3):
>>        tracing/eprobe: Fix to add filter on eprobe description in README file
>>        selftests/ftrace: Fix eprobe syntax test case to check filter support
>>        selftests/ftrace: Fix probepoint testcase to ignore __pfx_* symbols
>>
>>
> 
> Reviewed-by: Steven Rostedt (Google) <rostedt@...dmis.org>
> 
> -- Steve
> 

For selftest patches in the series: (Assuming patches 2&3 depend on patch 1.)

Acked-by: Shuah Khan <skhan@...uxfoundation.org>

thanks,
-- Shuah