linux-kernel - Re: [PATCH] arm64: dts: qcom: sdm845-xiaomi-beryllium-tianma: Add reserved memory region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b47b5a49-6e68-c827-a88e-f61fb85521c8@gmail.com>
Date:   Thu, 26 Jan 2023 00:15:51 -0600
From:   Joel Selvaraj <joelselvaraj.oss@...il.com>
To:     Amit Pundir <amit.pundir@...aro.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Caleb Connolly <caleb.connolly@...aro.org>
Cc:     linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        dt <devicetree@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        phone-devel <phone-devel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: sdm845-xiaomi-beryllium-tianma: Add
 reserved memory region

Hi Amit Pundir,

I have a Poco F1 (EBBG) variant and I can confirm that the framebuffer
address is same for the EBBG variant too.

I did a quick check by running the following command based on this link[1]:

xiber:~$ strings /dev/disk/by-partlabel/xbl_a | grep "Display Reserved"

0x9D400000, 0x02400000, "Display Reserved",  AddMem, MEM_RES,
SYS_MEM_CAP, Reserv, WRITE_BACK_XN

So I think it's safe to move this to sdm845-xiaomi-beryllium-common.dtsi

Regards,
Joel Selvaraj

[1]
https://wiki.postmarketos.org/wiki/SDM845_Mainlining#Find_the_framebuffer_address




On 24/01/23 12:32, Amit Pundir wrote:
> Put cont splash memory region under the reserved-memory as
> confirmed by the downstream code for Tianma variant as well.
> 
> Signed-off-by: Amit Pundir <amit.pundir@...aro.org>
> ---
> This change should probably go in sdm845-xiaomi-beryllium-common but
> I don't have EBBG variant's downstream code nor the device to test.
> 
>  .../boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts      | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts
> index 8e176111e599..47cbf725b0e3 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts
> @@ -7,6 +7,14 @@
>  / {
>  	model = "Xiaomi Pocophone F1 (Tianma)";
>  	compatible = "xiaomi,beryllium", "qcom,sdm845";
> +
> +	reserved-memory {
> +		/* Cont splash region set up by the bootloader */
> +		cont_splash_mem: framebuffer@...00000 {
> +			reg = <0x0 0x9d400000 0x0 0x2400000>;
> +			no-map;
> +		};
> +	};
>  };
>  
>  &display_panel {