linux-kernel - Re: [PATCH 571/606] serial: sc16is7xx: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y9PcIKLIbmsLB8lQ@kroah.com>
Date:   Fri, 27 Jan 2023 15:13:52 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Cc:     kernel@...gutronix.de,
        Uwe Kleine-König <uwe@...ine-koenig.org>,
        Lee Jones <lee.jones@...aro.org>, linux-kernel@...r.kernel.org,
        Wolfram Sang <wsa@...nel.org>,
        Angel Iglesias <ang.iglesiasg@...il.com>,
        linux-i2c@...r.kernel.org, linux-serial@...r.kernel.org,
        Grant Likely <grant.likely@...aro.org>,
        Jiri Slaby <jirislaby@...nel.org>
Subject: Re: [PATCH 571/606] serial: sc16is7xx: Convert to i2c's .probe_new()

On Fri, Jan 27, 2023 at 02:17:51PM +0100, Uwe Kleine-König wrote:
> Hello Greg,
> 
> On Fri, Jan 27, 2023 at 12:45:52PM +0100, Greg Kroah-Hartman wrote:
> > On Fri, Jan 27, 2023 at 11:10:25AM +0100, Uwe Kleine-König wrote:
> > > On Wed, Nov 23, 2022 at 09:09:12AM +0100, Uwe Kleine-König wrote:
> > > > On Wed, Nov 23, 2022 at 07:36:52AM +0100, Jiri Slaby wrote:
> > > > > BTW is this a performance issue? I.e. does it slow down the boot?
> > > > 
> > > > I don't know the start motivation for Lee (who triggered the conversion
> > > > in b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() call-back
> > > > type")).
> > > > Looking at the git history, he created 1e98dcd77970 ("mfd: 88pm860x:
> > > > Move over to new I2C device .probe() call") converting a driver that
> > > > doesn't benefit immensely. The lookup is more expensive for drivers with
> > > > big .id_table, the converted driver has only one entry.
> > > > 
> > > > I think in the end is a mixture between:
> > > > 
> > > >  - A big part of the drivers doesn't benefit from the lookup.
> > > >  - For most other busses the probe function only gets a device parameter
> > > >    and no id (spi, platform, i3c). There are counter examples though:
> > > >    amba, usb. Didn't check further.
> > > 
> > > The discussion somehow ended here without a real result.
> > > 
> > > As of today's next master there are only 9 drivers left using .probe().
> > > So I'd like to stop this discussion and ask to apply the conversion for
> > > the sc16is7xx driver to be able to complete the conversion.
> > > 
> > > My plan is to drop the .probe callback as it is today after the next
> > > merge window. So I ask the serial maintainers to either take the patch
> > > under discussion for the next merge window or accept that the conversion
> > > is done together with the patch that drops .probe() that probably will
> > > go in via the i2c tree.
> > 
> > I don't see the patch anymore,
> 
> If you want to take a look:
> 
> 	b4 am 20221118224540.619276-572-uwe@...ine-koenig.org
> 
> or
> 
> 	https://lore.kernel.org/lkml/20221118224540.619276-572-uwe@kleine-koenig.org
> 
> > so I have no objection for it going through the i2c tree.
> 
> Can I interpret that as an Ack? :-)

Even better:

Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>