linux-kernel - Re: [PATCH 596/606] watchdog: ziirave_wdt: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230131170141.GA3598528@roeck-us.net>
Date:   Tue, 31 Jan 2023 09:01:41 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>
Cc:     Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        linux-i2c@...r.kernel.org, kernel@...gutronix.de,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, linux-watchdog@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 596/606] watchdog: ziirave_wdt: Convert to i2c's
 .probe_new()

On Fri, Nov 18, 2022 at 11:45:30PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/watchdog/ziirave_wdt.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/watchdog/ziirave_wdt.c b/drivers/watchdog/ziirave_wdt.c
> index d0e88875443a..21ca08a694ee 100644
> --- a/drivers/watchdog/ziirave_wdt.c
> +++ b/drivers/watchdog/ziirave_wdt.c
> @@ -593,8 +593,7 @@ static int ziirave_wdt_init_duration(struct i2c_client *client)
>  					 reset_duration);
>  }
>  
> -static int ziirave_wdt_probe(struct i2c_client *client,
> -			     const struct i2c_device_id *id)
> +static int ziirave_wdt_probe(struct i2c_client *client)
>  {
>  	int ret;
>  	struct ziirave_wdt_data *w_priv;
> @@ -732,7 +731,7 @@ static struct i2c_driver ziirave_wdt_driver = {
>  		.name = "ziirave_wdt",
>  		.of_match_table = zrv_wdt_of_match,
>  	},
> -	.probe = ziirave_wdt_probe,
> +	.probe_new = ziirave_wdt_probe,
>  	.remove = ziirave_wdt_remove,
>  	.id_table = ziirave_wdt_id,
>  };