| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <Y9TdO9MeNxkesIQE@pendragon.ideasonboard.com>
Date: Sat, 28 Jan 2023 10:30:51 +0200
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Andrzej Hajda <andrzej.hajda@...el.com>,
Neil Armstrong <neil.armstrong@...aro.org>,
Robert Foss <rfoss@...nel.org>,
Jonas Karlman <jonas@...boo.se>,
Jernej Skrabec <jernej.skrabec@...il.com>,
David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: display: bridge: sil,sii8620: convert to
dtschema
Hi Krzysztof,
Thank you for the patch.
On Fri, Jan 27, 2023 at 09:35:25PM +0100, Krzysztof Kozlowski wrote:
> Convert the Silicon Image SiI8620 HDMI/MHL bridge bindings to DT schema.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
> .../bindings/display/bridge/sil,sii8620.yaml | 107 ++++++++++++++++++
> .../bindings/display/bridge/sil-sii8620.txt | 33 ------
> 2 files changed, 107 insertions(+), 33 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml
> delete mode 100644 Documentation/devicetree/bindings/display/bridge/sil-sii8620.txt
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml b/Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml
> new file mode 100644
> index 000000000000..90532bb99161
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml
> @@ -0,0 +1,107 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/bridge/sil,sii8620.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Silicon Image SiI8620 HDMI/MHL bridge
> +
> +maintainers:
> + - Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> +
> +properties:
> + compatible:
> + const: sil,sii8620
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + items:
> + - const: xtal
> +
> + cvcc10-supply:
> + description: Digital Core Supply Voltage (1.0V)
> +
> + interrupts:
> + maxItems: 1
> +
> + iovcc18-supply:
> + description: I/O Supply Voltage (1.8V)
> +
> + reset-gpios:
> + maxItems: 1
> +
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> + unevaluatedProperties: false
> +
> + properties:
> + port@0:
> + $ref: /schemas/graph.yaml#/properties/port
> + description:
> + Video port for HDMI (encoder) input
> +
> + port@1:
> + $ref: /schemas/graph.yaml#/properties/port
> + description:
> + MHL to connector port
> +
> + required:
> + - port@0
Why port@0 only ?
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - cvcc10-supply
> + - interrupts
> + - iovcc18-supply
> + - reset-gpios
> + - ports
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + bridge@39 {
> + reg = <0x39>;
> + compatible = "sil,sii8620";
> + cvcc10-supply = <&ldo36_reg>;
> + iovcc18-supply = <&ldo34_reg>;
> + interrupt-parent = <&gpf0>;
> + interrupts = <2 IRQ_TYPE_LEVEL_HIGH>;
> + reset-gpios = <&gpv7 0 GPIO_ACTIVE_LOW>;
> + clocks = <&pmu_system_controller 0>;
> + clock-names = "xtal";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + mhl_to_hdmi: endpoint {
> + remote-endpoint = <&hdmi_to_mhl>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> + mhl_to_musb_con: endpoint {
> + remote-endpoint = <&musb_con_to_mhl>;
> + };
> + };
> + };
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/display/bridge/sil-sii8620.txt b/Documentation/devicetree/bindings/display/bridge/sil-sii8620.txt
> deleted file mode 100644
> index b05052f7d62f..000000000000
> --- a/Documentation/devicetree/bindings/display/bridge/sil-sii8620.txt
> +++ /dev/null
> @@ -1,33 +0,0 @@
> -Silicon Image SiI8620 HDMI/MHL bridge bindings
> -
> -Required properties:
> - - compatible: "sil,sii8620"
> - - reg: i2c address of the bridge
> - - cvcc10-supply: Digital Core Supply Voltage (1.0V)
> - - iovcc18-supply: I/O Supply Voltage (1.8V)
> - - interrupts: interrupt specifier of INT pin
> - - reset-gpios: gpio specifier of RESET pin
> - - clocks, clock-names: specification and name of "xtal" clock
> - - video interfaces: Device node can contain video interface port
> - node for HDMI encoder according to [1].
> -
> -[1]: Documentation/devicetree/bindings/media/video-interfaces.txt
> -
> -Example:
> - sii8620@39 {
> - reg = <0x39>;
> - compatible = "sil,sii8620";
> - cvcc10-supply = <&ldo36_reg>;
> - iovcc18-supply = <&ldo34_reg>;
> - interrupt-parent = <&gpf0>;
> - interrupts = <2 0>;
> - reset-gpio = <&gpv7 0 0>;
> - clocks = <&pmu_system_controller 0>;
> - clock-names = "xtal";
> -
> - port {
> - mhl_to_hdmi: endpoint {
> - remote-endpoint = <&hdmi_to_mhl>;
> - };
> - };
> - };
--
Regards,
Laurent Pinchart
Powered by blists - more mailing lists