linux-kernel - Re: [PATCH v1] media: i2c: ov5640: Implement get_mbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 28 Jan 2023 08:31:42 +0000
From:   Marcel Ziswiler <marcel.ziswiler@...adex.com>
To:     "jacopo.mondi@...asonboard.com" <jacopo.mondi@...asonboard.com>
CC:     "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "laurent.pinchart@...asonboard.com" 
        <laurent.pinchart@...asonboard.com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "slongerbeam@...il.com" <slongerbeam@...il.com>,
        Aishwarya Kothari <aishwarya.kothari@...adex.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Francesco Dolcini <francesco.dolcini@...adex.com>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "sakari.ailus@...ux.intel.com" <sakari.ailus@...ux.intel.com>,
        "mchehab@...nel.org" <mchehab@...nel.org>
Subject: Re: [PATCH v1] media: i2c: ov5640: Implement get_mbus_config

Hi Jacopo

On Fri, 2023-01-27 at 18:50 +0100, Jacopo Mondi wrote:
> Hi Marcel
> 
> On Fri, Jan 27, 2023 at 04:12:44PM +0100, Marcel Ziswiler wrote:
> > From: Aishwarya Kothari <aishwarya.kothari@...adex.com>
> > 
> > Implement the introduced get_mbus_config operation to report the
> > number of used data lanes on the MIPI CSI-2 interface.
> > 
> 
> OV5640 can operate in parallel mode too.

I admit, we totally neglected this.

> You can check how it currently configured with ov5640_is_csi2() and
> populate struct v4l2_mbus_config accordingly.

Makes sense. Let us incorporate this in a v2.

> Thanks
>    j

Thank you!

Cheers

Marcel

> > Signed-off-by: Aishwarya Kothari <aishwarya.kothari@...adex.com>
> > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@...adex.com>
> > 
> > ---
> > 
> >  drivers/media/i2c/ov5640.c | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> > 
> > diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
> > index e0f908af581b..42d43f0d1e1c 100644
> > --- a/drivers/media/i2c/ov5640.c
> > +++ b/drivers/media/i2c/ov5640.c
> > @@ -3733,6 +3733,19 @@ static int ov5640_init_cfg(struct v4l2_subdev *sd,
> >         return 0;
> >  }
> > 
> > +static int ov5640_get_mbus_config(struct v4l2_subdev *sd,
> > +                                  unsigned int pad,
> > +                                  struct v4l2_mbus_config *cfg)
> > +{
> > +       struct ov5640_dev *sensor = to_ov5640_dev(sd);
> > +
> > +       cfg->type = V4L2_MBUS_CSI2_DPHY;
> > +       cfg->bus.mipi_csi2.num_data_lanes = sensor->ep.bus.mipi_csi2.num_data_lanes;
> > +       cfg->bus.mipi_csi2.flags = 0;
> > +
> > +       return 0;
> > +}
> > +
> >  static const struct v4l2_subdev_core_ops ov5640_core_ops = {
> >         .log_status = v4l2_ctrl_subdev_log_status,
> >         .subscribe_event = v4l2_ctrl_subdev_subscribe_event,
> > @@ -3753,6 +3766,7 @@ static const struct v4l2_subdev_pad_ops ov5640_pad_ops = {
> >         .get_selection = ov5640_get_selection,
> >         .enum_frame_size = ov5640_enum_frame_size,
> >         .enum_frame_interval = ov5640_enum_frame_interval,
> > +       .get_mbus_config = ov5640_get_mbus_config,
> >  };
> > 
> >  static const struct v4l2_subdev_ops ov5640_subdev_ops = {
> > --
> > 2.36.1