linux-kernel - [PATCH] x86/hotplug: Remove incorrect comment about mwait_play

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230128003751.141317-1-srivatsa@csail.mit.edu>
Date:   Fri, 27 Jan 2023 16:37:51 -0800
From:   "Srivatsa S. Bhat" <srivatsa@...il.mit.edu>
To:     tglx@...utronix.de, mingo@...hat.com, x86@...nel.org,
        peterz@...radead.org, hpa@...or.com
Cc:     bp@...en8.de, dave.hansen@...ux.intel.com,
        rafael.j.wysocki@...el.com, paulmck@...nel.org, jgross@...e.com,
        seanjc@...gle.com, thomas.lendacky@....com,
        linux-kernel@...r.kernel.org, imammedo@...hat.com,
        amakhalov@...are.com, ganb@...are.com, ankitja@...are.com,
        bordoloih@...are.com, keerthanak@...are.com, blamoreaux@...are.com,
        namit@...are.com, wyes.karny@....com, lewis.carroll@....com,
        pv-drivers@...are.com, virtualization@...ts.linux-foundation.org,
        kvm@...r.kernel.org, xen-devel@...ts.xenproject.org,
        srivatsa@...il.mit.edu
Subject: [PATCH] x86/hotplug: Remove incorrect comment about mwait_play_dead()

From: "Srivatsa S. Bhat (VMware)" <srivatsa@...il.mit.edu>

The comment that says mwait_play_dead() returns only on failure is a
bit misleading because mwait_play_dead() could actually return for
valid reasons (such as mwait not being supported by the platform) that
do not indicate a failure of the CPU offline operation. So, remove the
comment.

Suggested-by: Thomas Gleixner <tglx@...utronix.de>
Signed-off-by: Srivatsa S. Bhat (VMware) <srivatsa@...il.mit.edu>
---
 arch/x86/kernel/smpboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 55cad72715d9..9013bb28255a 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -1833,7 +1833,7 @@ void native_play_dead(void)
 	play_dead_common();
 	tboot_shutdown(TB_SHUTDOWN_WFS);
 
-	mwait_play_dead();	/* Only returns on failure */
+	mwait_play_dead();
 	if (cpuidle_play_dead())
 		hlt_play_dead();
 }
-- 
2.25.1