[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <5279D4E4-3B47-49A4-AD68-DB4B5C121594@goldelico.com>
Date: Sun, 29 Jan 2023 19:56:56 +0100
From: "H. Nikolaus Schaller" <hns@...delico.com>
To: Paul Cercueil <paul@...pouillou.net>
Cc: Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
周琰杰 <zhouyanjie@...yeetech.com>,
linux-mips@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, letux-kernel@...nphoenux.org
Subject: Re: [PATCH] MIPS: DTS: CI20: fix otg power gpio
> Am 29.01.2023 um 19:47 schrieb Paul Cercueil <paul@...pouillou.net>:
>
> Le dimanche 29 janvier 2023 à 18:48 +0100, H. Nikolaus Schaller a
> écrit :
>> According to schematics it is PF15 and not PF14 (MIC_SW_EN).
>> Seems as if it was hidden and not noticed during testing since
>> there is no sound DT node.
>>
>> Fixes: 158c774d3c64 ("MIPS: Ingenic: Add missing nodes for Ingenic
>> SoCs and boards.")
>> Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>
>
> I missed it, but every time you have a Fixes: tag, you also need to add
> below:
> Cc: stable@...r.kernel.org
Ah, yes. I missed this too. Checkpatch could have warned but doesn't...
> unless the bug you fix is in one of the RCs (and not in a released
> kernel).
>
> I think you should send a V2 with this tag (and my ACK).
Will do asap.
BR and thanks,
Nikolaus
>
> Cheers,
> -Paul
>
>> ---
>> arch/mips/boot/dts/ingenic/ci20.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts
>> b/arch/mips/boot/dts/ingenic/ci20.dts
>> index 9819abb2465dd..a276488c0f752 100644
>> --- a/arch/mips/boot/dts/ingenic/ci20.dts
>> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
>> @@ -115,7 +115,7 @@ otg_power: fixedregulator@2 {
>> regulator-min-microvolt = <5000000>;
>> regulator-max-microvolt = <5000000>;
>>
>> - gpio = <&gpf 14 GPIO_ACTIVE_LOW>;
>> + gpio = <&gpf 15 GPIO_ACTIVE_LOW>;
>> enable-active-high;
>> };
>> };
>
Powered by blists - more mailing lists