linux-kernel - Re: [PATCH] MIPS: DTS: CI20: fix otg power gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <167505467359.23017.2124580706077477317@noble.neil.brown.name>
Date:   Mon, 30 Jan 2023 15:57:53 +1100
From:   "NeilBrown" <neilb@...e.de>
To:     "Paul Cercueil" <paul@...pouillou.net>
Cc:     "H. Nikolaus Schaller" <hns@...delico.com>,
        "Rob Herring" <robh+dt@...nel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
        "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>,
        周琰杰 <zhouyanjie@...yeetech.com>,
        linux-mips@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, letux-kernel@...nphoenux.org
Subject: Re: [PATCH] MIPS: DTS: CI20: fix otg power gpio

On Mon, 30 Jan 2023, Paul Cercueil wrote:
> Le dimanche 29 janvier 2023 à 18:48 +0100, H. Nikolaus Schaller a
> écrit :
> > According to schematics it is PF15 and not PF14 (MIC_SW_EN).
> > Seems as if it was hidden and not noticed during testing since
> > there is no sound DT node.
> > 
> > Fixes: 158c774d3c64 ("MIPS: Ingenic: Add missing nodes for Ingenic
> > SoCs and boards.")
> > Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>
> 
> I missed it, but every time you have a Fixes: tag, you also need to add
> below:
> Cc: stable@...r.kernel.org

I don't think you do any more.  The stable team grabs anything that
looks even vaguely like a fix and applies it.  Having a valid Fixes tag
is enough for the stable team to take interest.

NeilBrown


> 
> unless the bug you fix is in one of the RCs (and not in a released
> kernel).
> 
> I think you should send a V2 with this tag (and my ACK).
> 
> Cheers,
> -Paul
> 
> > ---
> >  arch/mips/boot/dts/ingenic/ci20.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/mips/boot/dts/ingenic/ci20.dts
> > b/arch/mips/boot/dts/ingenic/ci20.dts
> > index 9819abb2465dd..a276488c0f752 100644
> > --- a/arch/mips/boot/dts/ingenic/ci20.dts
> > +++ b/arch/mips/boot/dts/ingenic/ci20.dts
> > @@ -115,7 +115,7 @@ otg_power: fixedregulator@2 {
> >                 regulator-min-microvolt = <5000000>;
> >                 regulator-max-microvolt = <5000000>;
> >  
> > -               gpio = <&gpf 14 GPIO_ACTIVE_LOW>;
> > +               gpio = <&gpf 15 GPIO_ACTIVE_LOW>;
> >                 enable-active-high;
> >         };
> >  };
> 
>