linux-kernel - RE: [PATCH V5 1/1] clk: imx8mp: Alias M7 SRC/DIV to M7 CORE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AS8PR06MB74325B5E249EC287F052518BD7D39@AS8PR06MB7432.eurprd06.prod.outlook.com>
Date:   Mon, 30 Jan 2023 07:44:22 +0000
From:   LI Qingwu <qing-wu.li@...ca-geosystems.com.cn>
To:     Abel Vesa <abel.vesa@...aro.org>, Stephen Boyd <sboyd@...nel.org>,
        Peng Fan <peng.fan@....com>
CC:     "abelvesa@...nel.org" <abelvesa@...nel.org>,
        "mturquette@...libre.com" <mturquette@...libre.com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "linux-imx@....com" <linux-imx@....com>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "18701859600@....com" <18701859600@....com>,
        GEO-CHHER-bsp-development 
        <bsp-development.geo@...ca-geosystems.com>,
        Marco Felsch <m.felsch@...gutronix.de>
Subject: RE: [PATCH V5 1/1] clk: imx8mp: Alias M7 SRC/DIV to M7 CORE



> -----Original Message-----
> From: Abel Vesa <abel.vesa@...aro.org>
> Sent: Sunday, January 29, 2023 2:39 AM
> To: Stephen Boyd <sboyd@...nel.org>; LI Qingwu
> <Qing-wu.Li@...ca-geosystems.com.cn>; Peng Fan <peng.fan@....com>
> Cc: LI Qingwu <Qing-wu.Li@...ca-geosystems.com.cn>; abelvesa@...nel.org;
> mturquette@...libre.com; shawnguo@...nel.org; s.hauer@...gutronix.de;
> kernel@...gutronix.de; festevam@...il.com; linux-imx@....com;
> linux-clk@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> linux-kernel@...r.kernel.org; 18701859600@....com;
> GEO-CHHER-bsp-development <bsp-development.geo@...ca-geosystems.com>;
> Marco Felsch <m.felsch@...gutronix.de>
> Subject: Re: [PATCH V5 1/1] clk: imx8mp: Alias M7 SRC/DIV to M7 CORE
> 
> [Some people who received this message don't often get email from
> abel.vesa@...aro.org. Learn why this is important at
> https://aka.ms/LearnAboutSenderIdentification ]
> 
> This email is not from Hexagon's Office 365 instance. Please be careful while
> clicking links, opening attachments, or replying to this email.
> 
> 
> On 23-01-18 11:00:36, Stephen Boyd wrote:
> > Quoting Abel Vesa (2023-01-16 06:28:33)
> > > On 23-01-11 11:10:30, LI Qingwu wrote:
> > > > Defined IMX8MP_CLK_M7_SRC and IMX8MP_CLK_M7_DIV in
> imx8mp-clock.h
> > > > but never assigned. It will cause the system to hang if using them.
> > > > Alias IMX8MP_CLK_M7_SRC and IMX8MP_CLK_M7_DIV to
> > > > IMX8MP_CLK_M7_CORE for backward compatibility.
> > > >
> > > > Fixes: 8c83a8ff4dd9 (clk: imx8mp: use imx8m_clk_hw_composite_core
> > > > to simplify code)
> > > > Reviewed-by: Marco Felsch <m.felsch@...gutronix.de>
> > > > Reviewed-by: Abel Vesa <abel.vesa@...aro.org>
> > > > Signed-off-by: LI Qingwu <Qing-wu.Li@...ca-geosystems.com.cn>
> > >
> > > Stephen, can you please pick this up yourself?
> > >
> >
> > Is it needed for clk-fixes? When did the system start hanging?
> 
> Li, Peng, can you provide some details here?

Since IMX8MP_CLK_M7_SRC and IMX8MP_CLK_M7_DIV were not assigned,
if using any one of them in device tree, Linux system hanging after start M7 core.